Don't show anything if there is no tour for the page

First, thanks for all the work put into Tours!

I agree with the issue statement that if there is no Tour available the link should not there. But on a UX perspective, what makes sense for the user is what we should define as the default: so I would argue that there shouldn't be any setting to give the option, the trigger button should just be hidden by default if there is no Tour available.

Another controversial point about this implementation, even if the issue isn't about this, is the placement of the Tour button trigger itself. The way the Navigation & Top Bar are supposed to work is:

• The left sidebar navigation is for site-wide elements, that will appear on all pages regardless on where the user is. That ensures that the Navigation remains consistent across the UI without elements disappearing based on the page (which would confuse users)
• The Top Bar is meant to hold any "contextual" elements relative to the existing page you are in

So based on this, it doesn't make sense to have a Tour link at the top of the main Navigation, taking up valuable space. But if it will also show&hide based on context, its place is not the left sidebar: its place is the Top bar. I see this was agreed in ✨ Integrate with the new experimental navigation module Fixed without any input from the Navigation maintainers, who could have provided this guidance prior to implementing it.

So my recommendation would be to completely remove it from the Navigation (and avoid having to do magic to hide the Tour as a menu item) and implement the Tour on the Top Bar appearing only when necessary.

+1 to all of this!

So this is my plan

For this ticket
1. Add a configuration option to hide the button if no tips found
2. Update hook, schema, and everything

This should be easy and I can knock out tomorrow at the latest

Open a new ticket
1. Remove all code for navigation integration. Will put on the module page and README if users want to use tour with the navigation module they'll have to place the block somewhere for now.
2. Add some styling so the button doesn't look like windows 98

Open a postponed ticket
1. Once navigation module top bar is implemented tour will use that.

Thoughts?

Opened 📌 Remove default integration with Navigation Active which is in review
Opened 📌 Integrate with navigation top bar Postponed which is postponed
Opened 📌 Better style tour block button Active which is WIP

Now to start this one

I applied the patch, ran drush updb, and the setting appeared. Switching it on immediately works as the setting page does not have a tour.

Turning it off does require a cache clear to get the No Tour button to come back, but I feel that is acceptable.

Marking as RTBC.

Automatically closed - issue fixed for 2 weeks with no activity.