- Issue created by @rkoller
- πΊπΈUnited States smustgrave
Very good point.
Wonder if this would be an issue if we fix β¨ Decouple tour triggering from the toolbar Needs work
- π©πͺGermany rkoller NΓΌrnberg, Germany
oh also a very good point of yours. i've quickly skimmed through the comments, in particular the point about users without access to the toolbar mitigating their ability to take a tour, i consider important. another point that make things complicated is when the workspaces module (no integration in the navigation yet at all) and https://www.drupal.org/project/environment_indicator β are installed. since the tours button isnt a regular menu item and the space aside regular top level menu items is limited that might be tricky. so decoupling the tour trigger from the navigation might be actually a good idea.
i've quickly applied the latest patch, even though it applied successfully, i am unable to see any button anywhere outside the navigation.. based on the fact that the new navigation is on the left side of the window that narrows down the number of potential positions where to place the button anyway, for LTR my initial gut feeling would be the upper right corner. only problem with that option is that there is the top bar, a submodule of the navigation module. at the moment it is not really functional, but as soon as the functionality gets in and folks install it, that might complicate things with the idea of placing a button in the upper right corner in case the button should be decoupled from navigation. or would it make sense (and be possible at all) to make it flexible, when no navigation module is there place the button in the upper right corner when the button is there add it for example to the top bar?
- πΊπΈUnited States smustgrave
It never would of flown for core but wonder in contrib if we have a floating icon if that would address all issues
- π©πͺGermany rkoller NΓΌrnberg, Germany
hm a floating icon might be an idea. but the potential positions are limited. basically the upper right corner or the lower right corner. in the lower right there might be a conflict in case editoria11y is installed (not sure what other modules there are? while in the upper right corner there might be a conflict with the top bar submodule of the navigation module. and being a floating icon it would be position absolute. but the question is does one need to scroll down a page and then still be able to access a tour? usually you decide to access a tour when you come to a page?
- πΊπΈUnited States smustgrave
So currently the new navigation bar I believe also has removed the "Edit" button for contextual links. Wonder if we can follow the same solution. β¨ Integrate with Workspaces Active does
- Status changed to Postponed
6 months ago 4:00pm 19 August 2024 - πΊπΈUnited States smustgrave
β¨ Allow Tours to be taken by users that cannot access the Toolbar (e.g. anonymous users) Postponed lets land this first as I think we need the block for the new navigation.
- Status changed to Active
5 months ago 5:07pm 26 August 2024 - πΊπΈUnited States smustgrave
Bumping in replace of π Tour and No Tour available button labels should not be required, and don't work on every page Active
Looking into this however before start I 'd like to confirm regarding position of tour button to support tour for experimental navigation module. Should we display the "tour button" above "create" menu of navigation sidebar(attached the screenshot & follow #7 β¨ Integrate with Workspaces Active shared link)
- Assigned to pooja_sharma
- Merge request !68Resolve #3444843 "Integrate tour with navigation" β (Merged) created by pooja_sharma
- Issue was unassigned.
- Status changed to Needs review
5 months ago 7:14am 9 September 2024 Integrated Admin toolbar "tour Button" with Navigation, tried to reuse the existing block rather than create new plugins so that code remain centralised , reused the existing navigation approach for rendering tour component so that existing navigation code remain sync, attached the screenshots as well for reference.
Please review, moving NR.
Attached the screenshots as well for reference. PLease review, moving NR.
- Status changed to RTBC
5 months ago 1:48pm 9 September 2024 -
pooja_sharma β
committed bc09ae89 on 2.0.x
Resolve #3444843 "Integrate tour with navigation"
-
pooja_sharma β
committed bc09ae89 on 2.0.x
- Status changed to Fixed
5 months ago 2:14pm 9 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.