- ๐ณ๐ฟNew Zealand quietone
This extension is being deprecated, see ๐ฑ [Meta] Tasks to deprecate Tour module Fixed . It will be removed from core and moved to a contrib project, ๐ [11.x] [Meta] Tasks to remove Tour Postponed .
This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project โ and the Extensions approved for removal โ policies.
- Status changed to Needs work
8 months ago 2:12pm 23 April 2024 - Assigned to smustgrave
- Merge request !37Issue #2069073 by pfrenssen, idimopoulos, thejimbirch, claudiu.cristea,... โ (Merged) created by smustgrave
- Status changed to Needs review
4 months ago 1:58am 17 August 2024 - ๐บ๐ธUnited States smustgrave
Had to change a number of things around but what about this?
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
I've retested this another time. Before things had worked both for anonymous users and my admin account. but now with ๐ Route parameters appear broken Fixed in when i've retried things, tours were available for my admin user but not for an anonymous user. my setup was:
- gave the
access tours</coder> permission to anon, authenticated, content editor and admin role</li> <li>created to tours one with the route </li> </ul> <code>entity.node.canonical - node:1
the other
entity.node.canonical - node:2
- created two nodes
- on
admin/structure/block
i've added theTour button
to theheader
section in olivero
the problems are:
- both tours are available for the admin role while both tours are not available for the anonymous role in a private window.
- when i place and save the tour button block on the block layout page (either for claro or olivero) the tour for the block layout page is auto started. that doesnt happen when i try to add any other block. and the start of the tour happens again if i add the tour button another time
- gave the
- Issue was unassigned.
- Status changed to Needs work
4 months ago 10:43pm 17 August 2024 - ๐บ๐ธUnited States smustgrave
Sounds like needs slightly more work.
Will try and find time next week but un-assigning incase anyone wants a crack.
- Status changed to Needs review
4 months ago 11:45pm 19 August 2024 - ๐บ๐ธUnited States smustgrave
both tours are available for the admin role while both tours are not available for the anonymous role in a private window.
Wouldn't that be correct? Purpose of adding the block is so it can be blocked outside the toolbar. If anonymous doesn't have access to the toolbar they shouldn't have access to the content there.
when i place and save the tour button block on the block layout page (either for claro or olivero) the tour for the block layout page is auto started. that doesnt happen when i try to add any other block. and the start of the tour happens again if i add the tour button another time
actually seems like it was a bug with the js where it wasn't checking for "tour=" but just looking for "tour" which the block name triggered.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
#117.2 got fixed after pulling the latest changes. looks good!
#117.1 hmm i have given the access tour permission to anonymous, authenticated, content editor and administrator. and the route for the test tour is
entity.node.canonical - node:2
and i have added the tour button in the header section of the block layout page.that is my setting. now:
Wouldn't that be correct? Purpose of adding the block is so it can be blocked outside the toolbar. If anonymous doesn't have access to the toolbar they shouldn't have access to the content there.
but isnt the issue title
Allow Tours to be taken by users that cannot access the Toolbar (e.g. anonymous users)
so my expectation would be that me as an anonymous user who has the permission to access a tour and not the toolbar would also be able to start a tour by clicking the take a tour of this page button? but the results are:anonymous:
clicking the take a tour button on node 4 in olivero -> no effect
clicking the take a tour button on node 2 in olivero -> no effect (even though there is a tour available)admin (with admin_toolbar shown)
clicking the take a tour button on node 4 in olivero not the admin_toolbar-> no effect
clicking the take a tour button on node 4 in olivero not the admin_toolbar -> the tour is shown. position for the tip is right and the tip gets somehow hidden and inaccessible underneath the admin_toolbar in part. mouse users would be unable to access the close button
- ๐บ๐ธUnited States smustgrave
No I think that other issue title isnโt correct. That ticket we decoupled the toolbar classes from tour.
I donโt know of any feature thatโs in the toolbar that anonymous users have access to.
-
smustgrave โ
committed 8477f298 on 2.0.x
Issue #2069073 by pfrenssen, idimopoulos, thejimbirch, claudiu.cristea...
-
smustgrave โ
committed 8477f298 on 2.0.x
- Status changed to Fixed
4 months ago 3:49pm 26 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.