- Issue created by @herved
- Merge request !9440Ensure the UI dialog instance exists/is valid in Drupal.dialog.resetSize. β (Open) created by herved
- Status changed to Needs review
6 months ago 8:10pm 6 September 2024 - π§πͺBelgium herved
Moving to needs review, thanks.
PS: It seems nightwatch has intermittent failures these days, phpunit as well
- π§πͺBelgium herved
Linking π Error: Cannot read properties of undefined (reading 'settings')β¨ with dialog.position.js Needs work as possibly related (but not quite).
- π§πͺBelgium herved
I believe π Avoid random failures in JavascriptTestBase when testing functionality in a dialog Needs work is also related, as I mentioned in #6.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π΅πΉPortugal dxvargas
I just want to confirm the RTBC.
The new version of the MR, after the last two commits managed to fix the problems in the pipeline I had before. - π«π·France nod_ Lille
I can't seem to replicate the test failures. When I run the tests without the immediate and early return fix from the dialog.position.js file it's still green.
- Status changed to Needs work
19 days ago 3:25pm 6 February 2025 - π¨π¦Canada joseph.olstad
While this patch deals with dialog
I was hoping it would also fix resizableI'm seeing this one:
Uncaught Error: cannot call methods on resizable prior to initialization; attempted to call method 'option'
Using a theme (not claro) for a node form.
This worked up until Drupal 10.4.xIn Drupal 11 there's a js error related to the media dialog.
- π«π·France Grimreaper France π«π·
Hi,
I have the same problem on a D10.4, with CKE5 in Layout Builder offcanvas, on a text format with the drupal media and/or the icon (from ui_icons) plugins.
When I click on the media insert button or the icon insert button, the error is immediately present in the browser's console.
- π§πͺBelgium herved
#17 Hi @grimreaper,
Yes I also noticed these errors get triggered with CKeditor: https://git.drupalcode.org/project/drupal/-/merge_requests/9440#note_398735
Is this MR here fixing your issue?There is also π Error: Cannot read properties of undefined (reading 'settings')β¨ with dialog.position.js Needs work which relates closely to this, maybe the patch there is is the proper fix?
- π«π·France Grimreaper France π«π·
Hi @herved,
I tried the MR changes without success.
But those errors were not blocking me it was something else related to dialogs which I had not been able to identify.
Like events not triggerred or incorectly triggered (not the right element, stuff like that).
So I pass to something else for until now.