- Issue created by @herved
- Merge request !9440Ensure the UI dialog instance exists/is valid in Drupal.dialog.resetSize. β (Open) created by herved
- Status changed to Needs review
3 months ago 8:10pm 6 September 2024 - π§πͺBelgium herved
Moving to needs review, thanks.
PS: It seems nightwatch has intermittent failures these days, phpunit as well
- π§πͺBelgium herved
Linking π Error: Cannot read properties of undefined (reading 'settings')β¨ with dialog.position.js Needs work as possibly related (but not quite).
- π§πͺBelgium herved
I believe π Avoid random failures in JavascriptTestBase when testing functionality in a dialog Needs work is also related, as I mentioned in #6.
The Needs Review Queue Bot β tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide β to find step-by-step guides for working with issues.
- π΅πΉPortugal dxvargas
I just want to confirm the RTBC.
The new version of the MR, after the last two commits managed to fix the problems in the pipeline I had before. - π«π·France nod_ Lille
I can't seem to replicate the test failures. When I run the tests without the immediate and early return fix from the dialog.position.js file it's still green.