- Issue created by @ramil g
- First commit to issue fork.
- ๐ธ๐ชSweden devdits
This patch can solve the problem until someone will create better solution.
- ๐จ๐ฆCanada joelpittet Vancouver
joelpittet โ changed the visibility of the branch 11.x to hidden.
- ๐จ๐ฆCanada joelpittet Vancouver
joelpittet โ changed the visibility of the branch 3457963-validate-viewname-in to hidden.
- Status changed to Needs review
4 months ago 2:38am 3 August 2024 - Status changed to Needs work
4 months ago 12:36am 4 August 2024 - ๐บ๐ธUnited States smustgrave
Seems to have a test failure so probably need test coverage for this one please
thanks!
- ๐ฉ๐ชGermany tobiasb Berlin
There are more use-cases
/node/add/รถรผรค
,/media/add/รถรผรค
,admin/structure/views/view/รถรผรค
. So any config name. - First commit to issue fork.
- Status changed to Needs review
3 months ago 12:30pm 11 September 2024 - ๐ฎ๐ณIndia arunkumark Coimbatore
I updated the condition to check for a valid name and path in
ViewAjaxController.php
. The view may be without a path(In case of blocks).Added new test cases for the Malicious strings in Name, Display Id, and Path.
- Status changed to Needs work
3 months ago 1:00pm 11 September 2024 - Status changed to Needs review
3 months ago 6:02am 12 September 2024 - ๐ฎ๐ณIndia arunkumark Coimbatore
The pipeline issue has been resolved.
Moving status to Review.
- Status changed to Needs work
3 months ago 2:07pm 12 September 2024 - ๐บ๐ธUnited States smustgrave
Test-only job runs without issue so tests still need work.
- ๐ฆ๐บAustralia jannakha Brisbane!
here's a solution to the underlying problem (which also solves #14)
https://www.drupal.org/project/drupal/issues/3475540 ๐ Throw an understandable exception when there is an attempt to load config entities with disallowed characters Needs work
- ๐ฎ๐ณIndia arunkumark Coimbatore
@jannakha The suggested fix for ASCII is already added,
/** * Validates given value to protect from unexpected requests. * * @param mixed $value * Given value for validation. * * @return bool * Returns TRUE if value valid, otherwise FALSE */ private function isValid(mixed $value): bool { return is_scalar($value) && mb_check_encoding($value, 'ASCII'); }
- ๐บ๐ธUnited States smustgrave
If ๐ Throw an understandable exception when there is an attempt to load config entities with disallowed characters Needs work solves more problems including this one this should probably be closed.
- ๐ฎ๐ณIndia arunkumark Coimbatore
@smustgrave
The handling in special character on ๐ Throw an understandable exception when there is an attempt to load config entities with disallowed characters Needs work for Configuration settings. But here we patched for Ajax views links. Is the fix on Config will help for the Views URLs?