- Issue created by @joachim
- First commit to issue fork.
- Merge request !8426Issue #3447072 by thejimbirch, alexpott, phenaproxima: Add 'recipe system' and... → (Open) created by kalpanajaiswal
- 🇮🇳India kalpanajaiswal
MR created to sort the $handlers_options in EntityReferenceItem::fieldSettingsForm().
- Status changed to Needs review
6 months ago 2:38pm 18 June 2024 - Status changed to Needs work
6 months ago 3:07pm 18 June 2024 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- 🇮🇳India kalpanajaiswal
kalpanajaiswal → changed the visibility of the branch 3453922-sort to hidden.
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch 3453922-sort-the-option to hidden.
- Status changed to Needs review
6 months ago 10:25am 24 June 2024 - 🇮🇳India ankitv18
Please review MR!8516, not sure about the target branch should be 11.x or 11.0.x
cc: @joachim - 🇮🇳India kalpanajaiswal
kalpanajaiswal → changed the visibility of the branch 3453922-sort-the-option to active.
- Status changed to Needs work
6 months ago 1:24pm 24 June 2024 - 🇮🇳India ankitv18
@smustgrave target branch should be 11.x or 11.0.x? will proceed accordingly to close one MR and rebase other MR if required.
- Merge request !8802Issue #3453922 "Entityreference::fieldSettingsForm() should sort the $handlers_options" → (Open) created by ankitv18
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch 3453922-entityreferenceitemfieldsettingsform-should-sort to hidden.
- 🇮🇳India ankitv18
ankitv18 → changed the visibility of the branch 3453922-sort-the-option to hidden.
- Status changed to Needs review
5 months ago 9:55am 17 July 2024 - 🇮🇳India ankitv18
Please review MR!8802, the work done by @kalpanajaiswal at first place. I have just created the clean MR against 11.x
cc: @quietone - Status changed to RTBC
5 months ago 10:37am 17 July 2024 - 🇮🇳India Vishal Choudhary Dharmshala
I have tested this Fork comment ! https://git.drupalcode.org/issue/drupal-3453922/-/tree/3453922-entityref...
Its working fine so I am Moving this RTBC.
Thanks For the Contribution. - Status changed to Needs work
5 months ago 2:35am 29 July 2024 - 🇳🇿New Zealand quietone
Sorting this does make sense. I do think a test of sorting should be added to prevent regressions.
@Vishal Choudhary, when reporting back that you tested a change, add the steps you made so that others can reproducible the results.
I have time, so I made 3 vocabularies on a standard install, Flowers, Trees and aardvarks. I applied the diff, cleared cache, and then added an entity reference field to the article content type. The options were not sorted.
So, there is work to do here. I have updated the issue summary.
- 🇮🇳India antojose
Updating the tag to mark it as available for the Contribution Day at Barcelona.
I tested the change and the handler options ('reference method') are sorted alphabetically (case insensitive, on the label). I updated the issue summary with steps to reproduce the results.
Concerning the feedback in #24 🐛 EntityReferenceItem::fieldSettingsForm() should sort the $handlers_options Active : the target bundles are sorted alphabetically but case sensitive (using natsort() and not natcasesort()) in the DefaultSelection plugin.