Add support for !service_closure custom tag in YamlFileLoader

Change seems simple enough

1) Drupal\Tests\Core\DependencyInjection\YamlFileLoaderTest::testParseDefinitionsWithProvider
Failed asserting that an object is an instance of class Symfony\Component\DependencyInjection\Argument\ServiceClosureArgument.
/builds/issue/drupal-3450516/core/tests/Drupal/Tests/Core/DependencyInjection/YamlFileLoaderTest.php:74
FAILURES!
Tests: 15, Assertions: 38, Failures: 1.

Test-only failure shows also has coverage.

Solution matches what's proposed so believe this is good.

Updated IS with more background

We should have a CR for this... something like [#3436859]

ONce #6 is done we can set this back to rtbc.

Added a change record.

Committed 72397df and pushed to 11.x. Thanks!

diff --git a/core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php b/core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php
index cbf282b181..39c4a771f5 100644
--- a/core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php
+++ b/core/lib/Drupal/Core/DependencyInjection/YamlFileLoader.php
@@ -494,9 +494,9 @@ private function resolveServices(mixed $value): mixed
               return $argument;
             }
 
-          if ('service_closure' === $value->getTag()) {
-            return new ServiceClosureArgument($this->resolveServices($argument));
-          }
+            if ($value->getTag() === 'service_closure') {
+                return new ServiceClosureArgument($this->resolveServices($argument));
+            }
 
         }
         if (is_array($value)) {

Fixed coding standards to comply with Symfony's and the rest of the file... spaces and yoda ifs...

Going to discuss with release managers about which releases this belongs in.

Discussed with @catch we agreed to put in 10.4.x - and possibly 10.3 and 11.0 - will discuss some more.

Discussed with @longwave and we agreed to backport this to 10.3.x

Automatically closed - issue fixed for 2 weeks with no activity.