Integrate Umami message

@ckrina:
demo_umami.profile does this by choosing to add a hook_toolbar (in the .profile). this item uses an inline_template build simply add the link and add a library to style it.

i might think this could be an menu block added thru Unami itself rather than something navigation needs to provide.

@SKAUGHT this is a message we have designed. It's place is the vertical navigation because it's where the site-wide messages belong. The Top Bar will only be used for contextual tools/actions that belong to the content/forms on the page.
Now that the Navigation is in core can be addressed.

markconroy → credited codeenigma → .

MR started - currently just adds the HTML to the block.

I'll try get to the CSS next week.

---
Thanks to Code Enigma for sponsoring my time to work on this.

Just to warn that this way will not work since Navigation module blocks may have titles

https://gyazo.com/2794d74881c590e9594540b9b8d09104

I would prefer if we create new block somehow here

Also probably move styles of that message on Navigation module level.

Probably we should add yet another theme hook in Navigation module. Style it there. And use it in Umami.

Thanks @finnsky

I've updated the MR now to use hook_preprocess_layout and added a new library to theme this.

Navigation collapsed:

Navigation expanded:

---
Thanks to The Confident for sponsoring my time to work on this.

Should the MR be marked non draft or still WIP?

I have another approach here. Gonna prepare MR

I really don't think that Umami or any other modules/themes should care about Navigation css.
Other modules may also want to add messages to Navigation.

So i've added 2 more theme hooks in navigation module + required css.

Please review.

How it looks

https://gyazo.com/324a0cee609afeef39b55e70f35de72f

I didn't found actual design so reused most styles from button

smustgrave → changed the visibility of the branch 3441100-integrate-umami-message to hidden.

Why use 3 notifications?

can be different type of that messages i believe. i added example of 3 messages types here.

So guess @markconroy which one should be used?

I'm happy to go with @finnsky's approach, looks very clean and will scale for other uses too.

---
Thanks to The Confident for sponsoring my time to work on this.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Fixed icon plus added common tooltip
https://gyazo.com/795757bee733d175de17e7815f40cc64

I just reviewed the code and it looks great but since this is providing an standardized solution and goes beyond the Umami message, then its place needs to be more generic and be moved to the top of the content region (above Dashboard, Content, Shortcuts) so it doesn't interfere with the navigation and behaves more as a normal message.

Checked the code and in general looks good.

Agree with @ckrina that would be great to move the messages to the top.

I think that would be interesting to provide a simpler way to implement messages by other modules. We can probably discuss it as part of ✨ Allow modules to hook into top of content/footer sections of new core navigation Active .

Thank you for your work on this one @finnsky!

I would really like to have it merged, but I'm afraid we need to get ✨ Allow modules to hook into top of content/footer sections of new core navigation Active in first.

Postponing this one on it to make it more explicit and have a better picture of the relationships between the issues.

Once we have ✨ Allow modules to hook into top of content/footer sections of new core navigation Active , it will be only necessary to implement the hook to have the Umami message visible in the new Navigation.

Working on it since the blocker issue is already merged.

Reimplemented the messages block once the parent issue has been merged.

Some screenshots of the new behavior:

Expanded:

Collapsed:

Collapsed with tooltip:

Some CSSLint issues need to be addressed before moving the issue to Needs Review.

Figured out how to make Gitlab CI happy.
Ready for Review now.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Back to Needs Review once conflicts have been solved.

Review steps

1. Install Umami demo site.
2. Enable navigation module.
3. Check Umami message on new navigation.

Everything works as expected, see the screenshot below:

Expanded:

Collapsed:

Collapsed with tooltip:

Perhaps we should have done it through the SDC right away. But it is quite possible to implement it through subsequent tasks.

Created follow-up issue 📌 [PP-1] Convert Navigation messages component to SDC Postponed to address the SDC conversion.

nod_ → closed merge request !9480

Committed c131a1e and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.