Fix Content Translation tests that rely on UID1's super user behavior

pradhumanjain2311 → made their first commit to this issue’s fork.

It was quite challenging to fix it as compare to the other similar child issues, as well interesting to make it working with required changes.

Addressed the mentioned changes superuser dependency code needs to remove & added respective permissions.

Please review, move NR.

Left some comments.

The tests shouldn't change but just getting the permissions right for the user.

I have updated minimum perms, also tried to reply on the queries.

Please review & passing for NR.

Saving credit for those who have worked on the issue thus far in meaningful way.

Left a comment on the MR.

I have tried to reply on query , PLease review moving NR

Sorry comment still stands we don't need to visit the permission page to add permissions. There are test methods like grantPermissions for such.

Removed the additional http request to assign perms , as per suggestion added API() to grant perms.

Left comment on the MR as well, Please review, moving NR.

Left comments on MR

I have left comment on the MR, maybe not sure we can keep it in NR for other reviewers (for last open thread)

Yea I don't think this is correct so will let someone pick up.

Going to mark to see what a core committer things. Alternative would be to create a role and use that ID for grantPermissions.

ContentTranslationTestBase which is used by several of these tests provides methods to assign the permissions for the administrator, editor and translator. I think we should continue to that approach and override those methods to assign the permissions in these tests. Such as is done in \Drupal\Tests\node\Functional\NodeTranslationUITest::getAdministratorPermissions(). Or am I missing something?

ContentTranslationTestBase which is used by several of these tests provides methods to assign the permissions for the administrator, editor and translator. I think we should continue to that approach and override those methods to assign the permissions in these tests. Such as is done in \Drupal\Tests\node\Functional\NodeTranslationUITest::getAdministratorPermissions().

Go through the whole code for suggested approach, used it, this addressed both reviewer feedback. Please review, move NR.

looks like a good update

Back to needs work because of differences in the html output of ContentTranslationRevisionTranslationDeletionTest.php

While debugging I have comment root user code ContentTranslationRevisionTranslationDeletionTest, due to which at that time I think need to add perms for editor (as test html output of 272 pages due to this happen), tried to add perm for appropriate user role, the tried to compare the output (ContentTranslationRevisionTranslationDeletionTest) with & without diff it's same.

PLease review , moving NR.

I have not reviewed the actual change, I'll leave that to someone else so I can commit this.

Feedback addressed

Committed and pushed to 11.x, 11.0.x, 10.4.x and 10.3.x because it is a test only change.

Thanks for sticking with this one @pooja_sharma

Thanks @smustgrave, @quietone for believing in me & guiding.

quietone → closed merge request !7587

@pooja_sharma, your welcome. And I appreciate your attention to the details , comments on what you found while working on an issue, and staying with the an issue until it is fixed. :-)

@quietone, Thanks for recognizing my efforts & dedication, your support, it means a lot to me . I 'd also like to mention, community members are really helpful & supportive, it's been wonderful opportunity to contribute here.

It's amazing to get appreciation from you , when I start contribution few months ago this feedback I got ✨ Disabled update module shouldn't produce a status report warning Needs work at that time understand your concerns & I thought one day I definitely 'll get appreciation from you & here it is finally 📌 Fix Content Translation tests that rely on UID1's super user behavior Active ;-)

Automatically closed - issue fixed for 2 weeks with no activity.