Regression: The drawer in Safari is missing the drop shadow

Please be aware of 🐛 The footer shadow disappears when a button is hovered Needs review because maybe the work here can close that other issue.

I added this merge request during the Portland DrupalCon 2024 Contribution day.

Could someone take a look at this when they have a moment?

I am not a front end expert but I imagine the values for -webkit-box-shadow and filter should be consistent. In the original CSS, the filter uses pixel values (px), but the added -webkit-box-shadow uses rem units.

We can directly use

box-shadow:
      0 0 72px rgba(0, 0, 0, 0.2),
      0 0 8px rgba(0, 0, 0, 0.04),
      0 0 40px rgba(0, 0, 0, 0.06);

As box shadow is supported in safari browser, there is no need of using -webkit-box-shadow

@marky was mentoring at my table and helped me in my first time contribution.

I'm continuing with this work. Whereas yesterday, I added a -webkit-drop-shadow to maintain Safari UI parity with Chrome and Firefox, I realized that the type of shape we are putting the shadow on was a rectangle and cshould be visually identical with box-shadow, which Safari supports. So I'm going to update the code accordingly.

Compared in a visual diff tool both the Safari and Chrome output, and it was the same.

I updated the issue summary to add the proposed resolution that @skyriter mentioned in #12.

I embedded the gif in the issue summary as well.

We should also add the steps to reproduce to the issue summary rather than in the merge request comment, @skyriter.

Those steps are now here in this issue. This should be ready once more to be reviewed.

The changes look fine and are working as expected on safari as well.

Believe this one has been tested and working fine in safari. Issue summary looks good also.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

There's already a branch for 11.x with an MR, don't think we need to start a new one.

ahsannazir → changed the visibility of the branch 3438878-regression-the-drawer to hidden.

Thanks @omahane

Test failure is unrelated was fixed when 🐛 After deleting a translated article, search wants to reindex it RTBC was reverted.

nod_ → closed merge request !7985

Committed and pushed 6fc1e6f2e9 to 11.x and 1f7b5b3b4c to 11.0.x and b17eca1c91 to 10.4.x and 590fb5278d to 10.3.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.