I'm running 2.0.1-alpha6 and ran into this issue after updating to PHP 8.3.
The patches in both #6 and #7 resolve the issue.
I'm unsure why all the extra stuff in #7 would be necessary so I believe #6 would be the more correct patch.
Marking status as "Reviewed and tested by the community"
This issue is closely related to the changes in 🐛 PHP 8.2 Deprecated function: Creation of dynamic property Needs work so I'm closing this in favor of that issue.
scottatdrake → created an issue.
scottatdrake → created an issue. See original summary → .
Resolved the deprecated dynamic property warning by declaring the $contexts property in the GroupPurlContext class. Additionally, removed unused imports and commented-out code, improved DocBlocks, and cleaned up code formatting for better readability and fix phpstan and drupalcs warnings.
I'm running out of time for today but intend to post a merge reqeust or patch in the next couple days.
scottatdrake → created an issue.
Drupal rector found some more. I believe the changes are related to the deprecation of the Symfony Event class.
This patch adds a missing "$query->accessCheck(TRUE);" that causes a fatal error. There may be more. I will add as I find them.
I started looking at this issue at #drupalconPortland2024. My understanding of the blocker here is that adding comments for 1,300+ classes in the format "Class [class name]" is not valuable, and there are too many to write manually. In fact, I think there may be a PHPStan rule prohibiting repeating the class name in the comment, though I'd need to verify that claim.
A couple of years have passed since this ticket was last updated. Now, we have LLM's like ChatGPT which can be pretty good at summarizing code. My idea is to write a script of some sort that passes the work of writing a meaningful description to one of them.
Reviewing such a large MR will still be a challenge but we may be able to automate the writing portion.
I'll wait for feedback before pursing this approach further.
I am not a front end expert but I imagine the values for -webkit-box-shadow and filter should be consistent. In the original CSS, the filter uses pixel values (px), but the added -webkit-box-shadow uses rem units.
We are out of time today. We spoke with the original opener of this issue, rkoller, via slack. The thread can be found at: https://drupal.slack.com/archives/C7AB68LJV/p1715202081200079
rkoller is using voiceover on a mac, and looking at the headings using voice over's rotor feature. The uploaded video nicely illustrates this.
Working on this issue during the mentored contribution DrupalCon Portland 2024.
Uploading patch that does the tasks described above.
scottatdrake → created an issue.
Uploading patch file of the described change.
scottatdrake → created an issue.
Closing the issue. It seems to have resolved itself and may have had to do with a stale opcache
(ie
https://www.drupal.org/project/twig_tweak/issues/3387341
🐛
Error: Class "Drupal\twig_tweak\TwigExtension" not found in Drupal\Component\DependencyInjection\Container->createService()
Active
). Introducing predeploy hooks may have played a part but I can't say how exactly.
scottatdrake → created an issue.
scottatdrake → created an issue.
The patch applies and, as far as I can tell, this module works fine in Drupal 10. Marking "Reviewed & tested by the community" and Priority to "Major" as the end of life for D9 approaches.
We are on 8.x-1.5. This patch worked for us.
I was able to reproduce the issue. The merge request appears correct to me.
I'm researching this same question in 2022. Admin Audit Trail for D8, 9, and 10 appears to be the most comprehensive and has reported usage of 1,000+ sites. https://www.drupal.org/project/admin_audit_trail →
Attaching patch. I'm not 110% certain this is correct but giving it a shot.
scottatdrake → created an issue.
#6 expands the scope beyond spelling errors and typos in the REST example to include code style changes across several example modules.
The changes themselves look fine to me.
Found a couple more.
Here is the patch.
scottatdrake → created an issue.