- Issue created by @Anybody
- ๐ฌ๐งUnited Kingdom aaron.ferris
aaron.ferris โ made their first commit to this issueโs fork.
- Assigned to aaron.ferris
- ๐ฎ๐ณIndia Mohd Sahzad
Mohd Sahzad โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia sarwan
sarwan_verma โ made their first commit to this issueโs fork.
- Status changed to Needs review
3 months ago 11:54am 5 April 2024 - ๐ฌ๐งUnited Kingdom aaron.ferris
Thanks for finishing the remaining bits @sarwan_verma
I need to test this.
- Status changed to Needs work
3 months ago 12:11pm 5 April 2024 - ๐ฌ๐งUnited Kingdom aaron.ferris
Fixed a couple of issues and tested this as far as I can tell the changes reach (IE for a font page for a particular user role, settings forms and the likes), I think this is good for a review.
- Status changed to Needs review
3 months ago 12:28pm 5 April 2024 - ๐ฉ๐ชGermany Anybody Porta Westfalica
Thanks @aaron.ferris!!
Still some left: https://git.drupalcode.org/issue/front-3438832/-/pipelines/138693 (Yellow)
- Status changed to Needs work
3 months ago 1:31pm 5 April 2024 - ๐ฌ๐งUnited Kingdom aaron.ferris
Pushed a change for eslint and the cspell flags that need attention, couple of things to note
1. One of the flags is because of a misspelling for an update hook thats fixing the misspelling so naturally didn't change this
2. The phpstan complaint is one im not sure we should change, given the current implementation is pretty standard practice (not sure how likely it is this class is being extended mind - IE if we want to fix the complaint). - ๐ฉ๐ชGermany Anybody Porta Westfalica
Thanks @aaron.ferris, yes cspell is fine. But eslint and phpstan fixes can be done, I think.
- ๐ฌ๐งUnited Kingdom aaron.ferris
Made the changes for the form class, if we want to change this to be a
phpstan.neon
file let me know. - Status changed to Needs review
3 months ago 2:58pm 5 April 2024 - Assigned to Grevil
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Whaooo this looks impressive!
I'll pass this to @Grevil for sign-off in the next week! Thanks!!