Fix remaining code style issues

aaron.ferris → made their first commit to this issue’s fork.

Mohd Sahzad → made their first commit to this issue’s fork.

Hi @Anybody,
I have created MR please review it.

Thanks for finishing the remaining bits @sarwan_verma

I need to test this.

Fixed a couple of issues and tested this as far as I can tell the changes reach (IE for a font page for a particular user role, settings forms and the likes), I think this is good for a review.

Thanks @aaron.ferris!!

Still some left: https://git.drupalcode.org/issue/front-3438832/-/pipelines/138693 (Yellow)

Pushed a change for eslint and the cspell flags that need attention, couple of things to note

1. One of the flags is because of a misspelling for an update hook thats fixing the misspelling so naturally didn't change this
2. The phpstan complaint is one im not sure we should change, given the current implementation is pretty standard practice (not sure how likely it is this class is being extended mind - IE if we want to fix the complaint).

Thanks @aaron.ferris, yes cspell is fine. But eslint and phpstan fixes can be done, I think.

Made the changes for the form class, if we want to change this to be a phpstan.neon file let me know.

Whaooo this looks impressive!

I'll pass this to @Grevil for sign-off in the next week! Thanks!!

@aaron.ferris Can we fix cspell pipeline too: https://git.drupalcode.org/issue/front-3438832/-/jobs/1252823#L54
weigth (Moreover this typo is concerning as it's a key used in .install file)

cc: @Grevil

I've set Cspell to ignore these lines as the update hook is fixing the spelling mistake in config.

@aaron.ferris instead of /* cSpell:disable */ can we add variable _CSPELL_WORDS: 'weigth' in the gitabl-ci.yml?

Not sure I really see the benefit in doing that, it’s not a word I’d expect to see used frequently it’s a typo.

Let’s see what the maintainer thinks.

I have thoroughly reviewed MR !12 and can confirm that it resolves all the PHPCS issues.
i moved it to RTBC.
THANKS!!

Thanks!!