- Issue created by @Anybody
- ๐ฌ๐งUnited Kingdom aaron.ferris
aaron.ferris โ made their first commit to this issueโs fork.
- Assigned to aaron.ferris
- ๐ฎ๐ณIndia mohd sahzad
Mohd Sahzad โ made their first commit to this issueโs fork.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 11:54am 5 April 2024 - ๐ฎ๐ณIndia sarwan_verma
Hi @Anybody,
I have created MR please review it. - ๐ฌ๐งUnited Kingdom aaron.ferris
Thanks for finishing the remaining bits @sarwan_verma
I need to test this.
- Status changed to Needs work
over 1 year ago 12:11pm 5 April 2024 - ๐ฌ๐งUnited Kingdom aaron.ferris
Fixed a couple of issues and tested this as far as I can tell the changes reach (IE for a font page for a particular user role, settings forms and the likes), I think this is good for a review.
- Status changed to Needs review
over 1 year ago 12:28pm 5 April 2024 - ๐ฉ๐ชGermany Anybody Porta Westfalica
Thanks @aaron.ferris!!
Still some left: https://git.drupalcode.org/issue/front-3438832/-/pipelines/138693 (Yellow)
- Status changed to Needs work
over 1 year ago 1:31pm 5 April 2024 - ๐ฌ๐งUnited Kingdom aaron.ferris
Pushed a change for eslint and the cspell flags that need attention, couple of things to note
1. One of the flags is because of a misspelling for an update hook thats fixing the misspelling so naturally didn't change this
2. The phpstan complaint is one im not sure we should change, given the current implementation is pretty standard practice (not sure how likely it is this class is being extended mind - IE if we want to fix the complaint). - ๐ฉ๐ชGermany Anybody Porta Westfalica
Thanks @aaron.ferris, yes cspell is fine. But eslint and phpstan fixes can be done, I think.
- ๐ฌ๐งUnited Kingdom aaron.ferris
Made the changes for the form class, if we want to change this to be a
phpstan.neon
file let me know. - Status changed to Needs review
over 1 year ago 2:58pm 5 April 2024 - Assigned to Grevil
- ๐ฉ๐ชGermany Anybody Porta Westfalica
Whaooo this looks impressive!
I'll pass this to @Grevil for sign-off in the next week! Thanks!!
- ๐ฎ๐ณIndia ankitv18
@aaron.ferris Can we fix cspell pipeline too: https://git.drupalcode.org/issue/front-3438832/-/jobs/1252823#L54
weigth (Moreover this typo is concerning as it's a key used in .install file)cc: @Grevil
- ๐ฌ๐งUnited Kingdom aaron.ferris
I've set Cspell to ignore these lines as the update hook is fixing the spelling mistake in config.
- ๐ฎ๐ณIndia ankitv18
@aaron.ferris instead of /* cSpell:disable */ can we add variable _CSPELL_WORDS: 'weigth' in the gitabl-ci.yml?
- Status changed to Needs work
about 1 year ago 4:24pm 21 July 2024 - ๐ฌ๐งUnited Kingdom aaron.ferris
Not sure I really see the benefit in doing that, itโs not a word Iโd expect to see used frequently itโs a typo.
Letโs see what the maintainer thinks.
- Status changed to Needs review
about 1 year ago 9:19pm 21 July 2024 - ๐ฎ๐ณIndia chandansha
I have thoroughly reviewed MR !12 and can confirm that it resolves all the PHPCS issues.
i moved it to RTBC.
THANKS!! - Status changed to RTBC
about 1 year ago 10:34am 23 July 2024 - Issue was unassigned.
- Status changed to Fixed
2 months ago 12:05am 27 May 2025 - ๐ฆ๐บAustralia elc
Pipeline confirms these issues have been fixed as a result of other issues.
https://git.drupalcode.org/project/front/-/pipelines/485919
One remaining spelling issue, plus the bad correction that needs to be reverted ๐ Revert fix of spelling which was an update to fix spelling Needs work
Automatically closed - issue fixed for 2 weeks with no activity.