- Issue created by @Project Update Bot
- last update
8 months ago 26 pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ these changes make this module compatible with Drupal 11! ๐
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
Bot run #11-121090This patch was created using these packages:
- drupal/upgrade_status: 4.1.0
- mglaman/phpstan-drupal: 1.2.7
- palantirnet/drupal-rector: 0.20.1
- last update
8 months ago 26 pass - First commit to issue fork.
- last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - ๐ฌ๐งUnited Kingdom jonathan1055
Would the maintainers of this module be OK if I used this automated MR to test a new feature request of Gitlab Templates? The feature will automatically test the project-update-bot-only branch against the Next Major core version (which is Drupal 11). Currently your tests at Drupal 10 pass, but the point of this automated issue is to test against D11. You could manually opt in to testing against D11 but the feature being developed in #3449621: Add rule for project-update-bot to test against next major โ will do this automatically for the merge request generated by the project update bot.
- ๐ฎ๐ณIndia ankitv18
This module is having require-dev dependency on drupal/feeds module which is not compatible with D11 so commented out OPT_IN_TEST_NEXT_MAJOR as it is failing the composer pipeline.
Change in Kernel Test taken a reference from https://www.drupal.org/project/drupal/issues/3393099 ๐ [PP-1] Move ExecutionContext and ExecutionContextFactory from TypedData to Validation namespace Postponed - ๐ฌ๐งUnited Kingdom jonathan1055
OK. The phpunit tests for Next Major are allowed to fail anyway, it would just show that the gitlab_templates change is working. It would not affect the pipelines in other issues or the scheduled pipelines, it would just test at D11 for these specific automatic MRs, which is ideal in your scenario. But if you'd prefer, I will find another project to test with.
- last update
6 months ago CI error - last update
6 months ago CI error - last update
6 months ago CI error - last update
6 months ago CI error - ๐ฎ๐ณIndia ankitv18
Hi @itamir MR!31 is ready for a review,
Warning in phpcs pipeline can be ignored as its a false positive and phpstan next minor deprecation warning is related to D12 - ๐ฎ๐ณIndia ankitv18
ankitv18 โ changed the visibility of the branch project-update-bot-only to hidden.
- First commit to issue fork.
- last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 23 pass, 2 fail - last update
6 months ago 26 pass - Status changed to RTBC
6 months ago 9:04am 5 June 2024 - ๐ฎ๐ณIndia deepakkm
Verified changes on local and working fine, hence RTBC
- last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Thanks for working on this. FYI this is blocking Search API Opensearch Drupal 11.x support. ๐ Drupal 11 readiness Active
- ๐ฎ๐นItaly itamair
Hi @here!
and sorry if I couldn't sync and stay on track with this ... BIT I had other priorities.
I could see some improving commits till some days ago, even after this was tagged as RTBC.I wouldn't really re-review and QA all this, as I can already see many strong Drupal devs on this.
Hence, are we sufficiently confident in merging this MR into the 8.x-1.x dev branch and deploy a new geofield 8.x-1.58 release, compatible with Drupal 11??? - Status changed to Needs review
5 months ago 1:01am 18 June 2024 - last update
5 months ago 26 pass This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module โ these changes make this module compatible with Drupal 11! ๐
Therefore these changes update theinfo.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot โ to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
Bot run #11-199781These packages were used to generate the fixes:
- drupal/upgrade_status: 4.3.2
- mglaman/phpstan-drupal: 1.2.11
- palantirnet/drupal-rector: 0.20.3
- last update
5 months ago 26 pass - ๐ฎ๐ณIndia ankitv18
Yes @itamir
Sorry actually I just considered the MR feedback didn't take a look on the issue status.
Please review the MR!31 and let me know any changes required. - last update
5 months ago 26 pass -
itamair โ
committed 88ebda0c on 8.x-1.x authored by
ankitv18 โ
Issue #3430742 by ankitv18, deepakkm, jonathan1055, kim.pepper, itamair...
-
itamair โ
committed 88ebda0c on 8.x-1.x authored by
ankitv18 โ
- Status changed to Fixed
5 months ago 7:22am 18 June 2024 - ๐ฎ๐นItaly itamair
Ok. MR!31 merged into 8.x-1.x dev, will be part of next Geofield 8.x-1.58 release ...
Thanks a lot for the great Job! - ๐น๐ทTurkey orkut murat yฤฑlmaz Istanbul
@itamair, thanks for the release:)
Automatically closed - issue fixed for 2 weeks with no activity.