- Issue created by @kim.pepper
-
kim.pepper โ
committed 4888591e on 3.x
#3452579 Drupal 11 readiness
-
kim.pepper โ
committed 4888591e on 3.x
-
kim.pepper โ
committed 9463ec7a on 3.x
Revert "#3452579 Drupal 11 readiness" This reverts commit...
-
kim.pepper โ
committed 9463ec7a on 3.x
- ๐ฎ๐ณIndia ankitv18
Hi @kimpepper Can I try to make the pipelines green?
- Status changed to Needs work
6 months ago 4:22am 6 June 2024 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
@ankitv18 go for it!
- Status changed to Needs review
6 months ago 7:59am 6 June 2024 - Status changed to Needs work
5 months ago 5:41am 12 June 2024 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Left some feedback.
- ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
I fixed a few codesniff issues in the 3.x branch so we can focus on just the 11.x compatibility here.
- ๐ฎ๐ณIndia ankitv18
Alright I'll rebase the branch with 3.x and let see if any further efforts is required as most of the work are covered.
- Status changed to Needs review
5 months ago 10:50am 12 June 2024 - ๐ฎ๐ณIndia ankitv18
PHPUnit Next Major pipeline: https://git.drupalcode.org/issue/search_api_opensearch-3452579/-/jobs/18...
this is already fixed in search_api 8.x-1.x https://git.drupalcode.org/project/search_api/-/blob/8.x-1.x/src/Backend...@kim.pepper now changes looks fine by you?
- Status changed to Needs work
5 months ago 11:10pm 12 June 2024 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
We need to fix the next major (11.x) test fail. This is what this issue is about.
- ๐ฎ๐ณIndia ankitv18
Next Major (11.x) phpunit pipeline is failing due to
PHP Fatal error: Declaration of Drupal\search_api\Backend\BackendPluginBase::__sleep() must be compatible with Drupal\Core\Plugin\PluginBase::__sleep(): array in /builds/issue/search_api_opensearch-3452579/web/modules/contrib/search_api/src/Backend/BackendPluginBase.php on line 337
And the above failure is already fixed in the search_api 8.x-1.x-dev once the search_api will release the new tag then this module next major pipeline will starts passing as there are no further tests are failing.
cc: @kim.pepper -
kim.pepper โ
committed 705fa440 on 3.x
Issue #3452579 by ankitv18, kim.pepper: Add Drupal 11.x support for...
-
kim.pepper โ
committed 705fa440 on 3.x
- Status changed to Fixed
5 months ago 2:33am 14 June 2024 - ๐ฆ๐บAustralia kim.pepper ๐โโ๏ธ๐ฆ๐บSydney, Australia
Committed to 3.x and 2.x. Thanks!
-
kim.pepper โ
committed c4f0934c on 2.x
Issue #3452579 by ankitv18, kim.pepper: Add Drupal 11.x support for...
-
kim.pepper โ
committed c4f0934c on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.