- Issue created by @Liam Morland
- First commit to issue fork.
- 🇮🇳India shubhamsprasad
shubhamsprasad → changed the visibility of the branch 3421188-allow-setting-header to hidden.
- First commit to issue fork.
- Merge request !6760Issue #3421188: Allow setting header row attributes in table.html.twig → (Open) created by govind_giri_goswami
- Status changed to Needs review
10 months ago 7:26pm 25 February 2024 - 🇮🇳India govind_giri_goswami
In both the table.html.twig template and the template_preprocess_table() function, we enabled the addition of attributes to the
- Status changed to Needs work
10 months ago 2:28pm 26 February 2024 - 🇺🇸United States smustgrave
Did a small review but seems to be a number of scope changes.
Solution doesn't match the proposed solution
Will need test coverage
If editing a core template they all will have to be updated and CR written.
- Status changed to Needs review
10 months ago 8:14am 4 March 2024 - 🇮🇳India govind_giri_goswami
The modifications to the template_preprocess_table() function enable the setting of attributes for tr elements within the thead of the table. This is achieved by introducing a check for row_attributes within the loop that processes header cells. If row_attributes are present, they are assigned to the respective header cell. Additionally, the row_attributes are merged with existing cell_attributes to ensure preservation of both cell and row attributes.
- Status changed to Needs work
10 months ago 2:52pm 4 March 2024 - 🇺🇸United States smustgrave
Still seems out of scope changes are still there.
Still missing tests
See just one template is updated and not the others.
No change record.
- Status changed to Needs review
10 months ago 5:44pm 7 March 2024 - Status changed to Needs work
10 months ago 5:51pm 7 March 2024