- Issue created by @longwave
- Status changed to Needs review
11 months ago 9:15pm 14 January 2024 - 🇬🇧United Kingdom longwave UK
I think the test fail means somehow the number of cache sets has been decreased in the standard profile?
$this->assertGreaterThanOrEqual(59, $performance_data->getCacheSetCount());
This is now consistently 53. But no other tests fail, so I don't think anything is broken - is this just an accidental performance improvement?
📌 Investigate variable database query counts in performance tests Active
- Status changed to Needs work
11 months ago 2:43pm 16 January 2024 - 🇬🇧United Kingdom longwave UK
Looks like 📌 Allow needs_destruction services to run on page cache hits Needs review will make this obsolete, destroying the services in the kernel itself is a much better idea.
- First commit to issue fork.
- Status changed to Needs review
11 months ago 6:22am 23 January 2024 - Status changed to Needs work
11 months ago 10:39am 23 January 2024 - 🇬🇧United Kingdom longwave UK
@arunkumark you've removed the code that sets up the configurator? The registerService method is no longer called by anything.
Still, I think this will be obsolete soon as per #8.
- Status changed to Postponed
11 months ago 3:39pm 30 January 2024 - 🇬🇧United Kingdom catch
Postponing this on 📌 Allow needs_destruction services to run on page cache hits Needs review which removes this subscriber altogether and is RTBC.
- Status changed to Closed: won't fix
11 months ago 11:20pm 30 January 2024 - 🇬🇧United Kingdom longwave UK
📌 Allow needs_destruction services to run on page cache hits Needs review landed so we don't need to do this.