- Issue created by @claudiu.cristea
- Status changed to Needs review
about 1 year ago 9:41pm 18 December 2023 - Status changed to Needs work
about 1 year ago 7:41am 19 December 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
You're right. In the parent issue, we focused on
type: label
and just exempted this one exception (see https://git.drupalcode.org/project/drupal/-/merge_requests/4567/diffs?co...).I think we can generalize the scope of this issue though π€
We should expand the test coverage in
\Drupal\KernelTests\Core\Config\SimpleConfigValidationTest::testSpecialCharacters()
(which was added in π Add validation constraint to `type: label` + `type: text`: disallow control characters Fixed ). - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
This blocks β¨ [PP-1] Allow plurals on bundle labels Postponed .
- Status changed to Needs review
9 months ago 8:05pm 27 March 2024 - π·π΄Romania claudiu.cristea Arad π·π΄
Tests green. Ready for review.
- Status changed to RTBC
9 months ago 2:51pm 28 March 2024 - πΊπΈUnited States smustgrave
1) Drupal\KernelTests\Core\Config\SimpleConfigValidationTest::testSpecialCharacters with data set "plural label" ('config_test.with_plural_label', 'label', Binary String: 0x03, null) Failed asserting that actual size 1 matches expected size 0. /builds/issue/drupal-3409588/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121 /builds/issue/drupal-3409588/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55 /builds/issue/drupal-3409588/core/tests/Drupal/KernelTests/Core/Config/SimpleConfigValidationTest.php:149 /builds/issue/drupal-3409588/vendor/phpunit/phpunit/src/Framework/TestResult.php:728 FAILURES! Tests: 69, Assertions: 206, Failures: 1.
Shows the test coverage for the change.
The moving of the constraint makes sense to me.
- Status changed to Needs work
9 months ago 11:25am 29 March 2024 - π¬π§United Kingdom alexpott πͺπΊπ
Let's test the other side of this. That other characters result in an error. Plus it would be great if the test content looked a little more realistic that just the character.
- π·π΄Romania claudiu.cristea Arad π·π΄
Let's test the other side of this. That other characters result in an error.
Just that the error message could be misleading because it might refer to
\x03