Contrib.social

Correct 'milli' in core/form.js

Open on Drupal.org →
Created on 5 December 2023, 10 months ago
Updated 23 February 2024, 7 months ago

Problem/Motivation

cspell identifies the use of 'milli' in this sentence as a misspelling.

   *   (due to limitations of jQuery.serialize()). That is deemed to be
   *   acceptable, because if the user forgot to attach a file, then the size of
   *   HTTP payload will most likely be small enough to be fully passed to the
   *   server endpoint within {milli}seconds. If a user mistakenly attached a
   *   wrong file and is technically versed enough to cancel the form submission
   *   (and HTTP payload) in order to attach a different file, then that
   *   edge-case is not supported here.

The use of milli first appeared in the patch at #1705618-21: Double click prevention on form submission → and was in commit 502e953.

Steps to reproduce

Proposed resolution

In 📌 Fix more words that are only misspelled in comments Fixed xjm suggested "the author meant to say something like"

   *   server endpoint within seconds, or even milliseconds. If a user
   *   mistakenly attached a wrong file and is technically versed enough to
   *   cancel the form submission (and HTTP payload) in order to attach a
   *   different file, then that edge-case is not supported here.

Remaining tasks

Determine the correct change so milli is not detected as a spelling error and the comment is correct.

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

10.2 ✨

Component
Javascript  →

Last updated about 5 hours ago

Created by

🇳🇿New Zealand quietone

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024