Fix more words that are only misspelled in comments

Created on 29 October 2023, 8 months ago
Updated 8 February 2024, 4 months ago

Problem/Motivation

More words to fix that are only in comments.

Steps to reproduce

Proposed resolution

  1. authless
  2. brion
  3. buildinfo
  4. clicksorter
  5. countquery
  6. customly
  7. filevalidationerror
  8. formvalidation
  9. hashmarks
  10. keyname
  11. killswitch
  12. mysite
  13. nameofbin
  14. rawurlencoded
  15. routable
  16. routeable
  17. timeframe
  18. typehinting
  19. unixtimestamp
  20. unpermissioned
  21. yourmodule

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

10.2 ✨

Component
OtherΒ  β†’

Last updated about 2 hours ago

Created by

πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @quietone
  • Status changed to Needs review 8 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand
  • Status changed to Needs work 8 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Seemed to cause a test failure.

  • First commit to issue fork.
  • πŸ‡ͺπŸ‡ΈSpain fjgarlin

    Rebased the MR to check a gitlab pipeline permission issue. Do not credit me here.

  • Status changed to Needs review 7 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    I rebased and fixed a few more. Also updated the list in the IS.

  • Status changed to Needs work 7 months ago
  • The Needs Review Queue Bot β†’ tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

  • Status changed to Needs review 7 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    The tests really are passing. Setting to needs review.

  • Status changed to RTBC 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Replacements seem fine, don't see anything added that makes the variables confusing or anything.

  • Status changed to Needs review 7 months ago
  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    Most of these seem fine but a question about "revisioning".

  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    'revisioning' is more complicated because it is used in a function name Drupal\Tests\layout_builder\FunctionalJavascript\InlineBlockTest::testInlineBlocksRevisioning. So that has been removed.

    I also found that some changes for mysite got lost.

  • Status changed to RTBC 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Should "revisioning" be added to the Drupal dictionary?

  • Status changed to Needs work 7 months ago
  • πŸ‡ΊπŸ‡ΈUnited States xjm

    @smustgrave:

    Should "revisioning" be added to the Drupal dictionary?

    Possibly. I had the same question for "refactoring". We're also probably going to add "revisionable", "revisionability", etc. Someone want to add a note to the meta about these things? Tagging "Needs followup" for that, although that translates to "Needs parent issue update" rather than "Needs new issue filed as followup" in this scenario..

    NW for a few things on the MR. Rest of the changes look great. Thanks!

  • Status changed to Needs review 7 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    Follow up made for 'milli' and parent meta update for the forms of 'revision'. Therefore removing tag.

  • Status changed to Needs work 7 months ago
  • The Needs Review Queue Bot β†’ tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

    This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

  • Status changed to Needs review 7 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    @xjm. thanks.

    Rebased and back to NR.

  • Status changed to Needs work 7 months ago
  • πŸ‡ΈπŸ‡°Slovakia poker10

    Not sure if we still need to agree what to do with "refactorings", but currently there are two different changes for this word (one to "any refactoring", second to "changes"):

    +++ b/core/lib/Drupal/Core/Asset/CssOptimizer.php
    @@ -106,8 +106,8 @@ protected function processFile($css_asset) {
    -   * it is not on the AssetOptimizerInterface, so future refactorings can make
    -   * it protected.
    +   * it is not on the AssetOptimizerInterface, so any future refactoring can
    +   * make it protected.
    
    +++ b/core/lib/Drupal/Core/Asset/CssOptimizer.php
    @@ -271,8 +271,8 @@ protected function processCss($contents, $optimize = FALSE) {
    -   * it is not on the AssetOptimizerInterface, so future refactorings can make
    -   * it protected.
    +   * it is not on the AssetOptimizerInterface, so future changes can make it
    +   * protected.
    

    I think the first is better than using the word "changes".

  • Status changed to Needs review 7 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    @poker10, thanks. I forgot there were two instances of 'refactorings'.

  • Status changed to RTBC 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Believe all feedback has been addressed.

  • Status changed to Needs work 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States xjm

    For my feedback on the MR. It's fine to scope that change to a followup, or to rewrite the sentence here, but that's a "making it worse" kind of change ATM. :) Thanks!

  • Status changed to Needs review 6 months ago
  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand

    Rebased, rebuilt dictionary.

    #21. This was just a typo and is now restored to HEAD.

  • Status changed to RTBC 6 months ago
  • πŸ‡ΊπŸ‡ΈUnited States smustgrave

    Rebase looks good

    • longwave β†’ committed 0b625d5a on 10.2.x
      Issue #3397490 by quietone, smustgrave, xjm, longwave, poker10: Fix more...
    • longwave β†’ committed a3decd9d on 11.x
      Issue #3397490 by quietone, smustgrave, xjm, longwave, poker10: Fix more...
  • Status changed to Fixed 5 months ago
  • πŸ‡¬πŸ‡§United Kingdom longwave UK

    Backported to 10.2.x to keep things in sync and make other backports easier, as this only changes comments.

    Committed and pushed a3decd9d43 to 11.x and 0b625d5ad4 to 10.2.x. Thanks!

  • πŸ‡³πŸ‡ΏNew Zealand quietone New Zealand
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024