Fix more words that are only misspelled in comments

Seemed to cause a test failure.

Rebased the MR to check a gitlab pipeline permission issue. Do not credit me here.

I rebased and fixed a few more. Also updated the list in the IS.

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

The tests really are passing. Setting to needs review.

Replacements seem fine, don't see anything added that makes the variables confusing or anything.

Most of these seem fine but a question about "revisioning".

'revisioning' is more complicated because it is used in a function name Drupal\Tests\layout_builder\FunctionalJavascript\InlineBlockTest::testInlineBlocksRevisioning. So that has been removed.

I also found that some changes for mysite got lost.

Should "revisioning" be added to the Drupal dictionary?

@smustgrave:

Should "revisioning" be added to the Drupal dictionary?

Possibly. I had the same question for "refactoring". We're also probably going to add "revisionable", "revisionability", etc. Someone want to add a note to the meta about these things? Tagging "Needs followup" for that, although that translates to "Needs parent issue update" rather than "Needs new issue filed as followup" in this scenario..

NW for a few things on the MR. Rest of the changes look great. Thanks!

Follow up made for 'milli' and parent meta update for the forms of 'revision'. Therefore removing tag.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

@xjm. thanks.

Rebased and back to NR.

Not sure if we still need to agree what to do with "refactorings", but currently there are two different changes for this word (one to "any refactoring", second to "changes"):

+++ b/core/lib/Drupal/Core/Asset/CssOptimizer.php
@@ -106,8 +106,8 @@ protected function processFile($css_asset) {
-   * it is not on the AssetOptimizerInterface, so future refactorings can make
-   * it protected.
+   * it is not on the AssetOptimizerInterface, so any future refactoring can
+   * make it protected.

+++ b/core/lib/Drupal/Core/Asset/CssOptimizer.php
@@ -271,8 +271,8 @@ protected function processCss($contents, $optimize = FALSE) {
-   * it is not on the AssetOptimizerInterface, so future refactorings can make
-   * it protected.
+   * it is not on the AssetOptimizerInterface, so future changes can make it
+   * protected.

I think the first is better than using the word "changes".

@poker10, thanks. I forgot there were two instances of 'refactorings'.

Believe all feedback has been addressed.

For my feedback on the MR. It's fine to scope that change to a followup, or to rewrite the sentence here, but that's a "making it worse" kind of change ATM. :) Thanks!

Rebased, rebuilt dictionary.

#21. This was just a typo and is now restored to HEAD.

Rebase looks good

Backported to 10.2.x to keep things in sync and make other backports easier, as this only changes comments.

Committed and pushed a3decd9d43 to 11.x and 0b625d5ad4 to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

quietone → closed merge request !5168