- Issue created by @mlncn
- Status changed to Needs review
over 1 year ago 4:35am 23 November 2023 - Merge request !5511Issue #3403535: Claro removes default styling from abbreviations (<abbr> tag) → (Closed) created by mlncn
- 🇮🇳India nitin shrivastava
Hey @mlncn,
i am not able to replicate this issue can you please provide some steps how to reproduce? - Status changed to Needs work
over 1 year ago 2:42pm 23 November 2023 - 🇺🇸United States smustgrave
@mlncn could you please add before/after screenshots to the issue summary as a UI change
Also steps to reproduce.
- Status changed to Postponed: needs info
over 1 year ago 6:18pm 14 December 2023 - Status changed to Needs review
7 months ago 11:14pm 15 September 2024 - 🇦🇺Australia pameeela
Issue still occurs and fix seems reasonable. Updated IS.
- 🇺🇸United States smustgrave
But the comment
* Fix duplicate border caused by normalize.css adding border-bottom without
* removing the text-decoration.Are we re-introducing that?
- 🇮🇳India nayana_mvr
I'm able to reproduce this issue on Drupal 11.x and the changes in MR!5511 fixes that. Regarding the comment
/** * Fix duplicate border caused by normalize.css adding border-bottom without * removing the text-decoration. */
It refers to the file
core/themes/stable9/css/core/assets/vendor/normalize-css/normalize.css
where the following style is written for abbr[title] :-/** * 1. Remove the bottom border in Chrome 57- * 2. Add the correct text decoration in Chrome, Edge, IE, Opera, and Safari. */ abbr[title] { border-bottom: none; /* 1 */ text-decoration: underline; /* 2 */ text-decoration: underline dotted; /* 2 */ }
I verified this in Chrome and safari, but there are no duplicate borders in any of them after this fix. Not sure whether there was any code change in
core/themes/stable9/css/core/assets/vendor/normalize-css/normalize.css
later.Noticed that
text-decoration
works differently in both browsers. Attaching the before and after(chrome and safari) screenshots for reference. - 🇺🇸United States smustgrave
Would be good if we can mark where this was fixed in normalize and thus answer the question of the code being remvoed about duplicate border.
- 🇺🇸United States smustgrave
So this code was added to core in #3079738: Add Claro administration theme to core → in 2019
Normalize.css was updated in 📌 Update normalize.css to the most recent version Fixed in 2020, where believe this was fixed from normalize. Will mark. - First commit to issue fork.
- 🇩🇪Germany tobiasb Berlin
Scope is claro. But claro does not remove the styling. ;-)
- 🇫🇷France nod_ Lille
Committed and pushed 79a49040099 to 11.x and 26519bfa19a to 11.0.x and d8e98d67400 to 10.4.x and 730dc82cf3d to 10.3.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.