Fix strict type errors: Convert FormattableMarkup to strings (complex replacement) in core Kernel tests

Split these changes from the parent issue, marking NW to make readability improvements.

Addressed feedback

All feedback/threads appear to be addressed.

MR needs rebasing

Rebased, seems like some of the changes were already addressed in a related issue.

Rebase seems good.

I found a stray character and left a question about using ...$args.

Fixed the stray % character. Perhaps we should get rid of the $args array in those sprintf calls and just add the values directly?

Perhaps we should get rid of the $args array in those sprintf calls and just add the values directly?

Removing that sounds like it could be a follow up as that could lead down a rabbit hole (I imagine)

I don't this it is a rabbit hole for reasons I mention in the MR. I wanted to use the suggestion feature for these two changes but it wasn't working for me \Drupal\Tests\system\Kernel\Form\ProgrammaticTest::doSubmitForm so I abandoned that idea.

Do we even need a $message here? Would make all these issues so much easier. Anyway, that's a topic for another day.

I agree, most of these don't need a message.

To get this moving again I made the changes I suggested.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Arg, I've had trouble with git with this issue. Should be sorted now.

Appears feedback has been addressed

Thank you @quietone, have looked over the last 3 commits and am happy with these changes.

Committed and pushed 955418c2df to 11.x and c9255990e0 to 10.3.x. Thanks!
Committed ac127f0 and pushed to 10.2.x. Thanks!

Backported to 10.2.x to keep tests aligned...

We should file a followup to change \Drupal\Tests\file\Kernel\FileManagedUnitTestBase::assertFileHooksCalled() to something like:

  public function assertFileHooksCalled($expected) {
    \Drupal::state()->resetCache();

    // Determine which hooks were called.
    $actual = array_keys(array_filter(file_test_get_all_calls()));

    // Determine if there were any expected that were not called.
    $uncalled = array_diff($expected, $actual);
    $this->assertEmpty($uncalled, sprintf('Expected hooks %s to be called but %s was not called.', implode(', ', $expected), implode(', ', $uncalled)));

    // Determine if there were any unexpected calls.
    $unexpected = array_diff($actual, $expected);
    $this->assertEmpty($unexpected, sprintf('Unexpected hooks were called: %s.', empty($unexpected) ? '(none)' : implode(', ', $unexpected)));
  }

The $this->assertTrue(FALSE is bizarre... but not added here.

mstrelan → closed merge request !5473

Automatically closed - issue fixed for 2 weeks with no activity.