- Issue created by @quietone
- Merge request !5095Replace REQUEST_TIME in plugins with direct container access β (Open) created by quietone
- last update
about 1 year ago 30,430 pass - Issue was unassigned.
- First commit to issue fork.
- Status changed to Needs review
10 months ago 1:29pm 13 February 2024 - π³π±Netherlands spokje
Seems like the excellent work of @quietone was overlooked due to this issue being stuck on Active instead of NR.
Updated the deprecation notices and CR to mention 10.3.0 and removed the now deemed superfluous deprecation tests.
- πΊπ¦Ukraine Taran2L Lviv
Added a few suggestion so this one is consistent with https://git.drupalcode.org/project/drupal/-/commit/fd75fa213472e2029fded...
Then, I see other issue here: π Replace REQUEST_TIME in rest of OO code (except for tests) Fixed , but it seems that at least some of the examples rom that issue actually should be here like field plugins?
- Status changed to Needs work
10 months ago 1:43pm 13 February 2024 - First commit to issue fork.
- Status changed to Needs review
10 months ago 2:00pm 13 February 2024 - Status changed to Needs work
10 months ago 2:45pm 13 February 2024 - Status changed to Needs review
10 months ago 2:51pm 13 February 2024 - Status changed to RTBC
10 months ago 2:54pm 13 February 2024 - πΊπΈUnited States smustgrave
Verified CR link is fixed and appears rest of threads have been addressed
- Assigned to Taran2L
- Status changed to Needs work
10 months ago 3:45pm 13 February 2024 - πΊπ¦Ukraine Taran2L Lviv
There is at least one more place where plugin with direct access exists, setting back to needs work ..
The identified plugins:
- \Drupal\Core\Field\Plugin\Field\FieldFormatter\TimestampFormatter - Status changed to Needs review
10 months ago 4:08pm 13 February 2024 - πΊπ¦Ukraine Taran2L Lviv
I've manually checked phpstan baseline file and all other occurrences are either in OO code without container access, or in tests (there are separate issues for that)
Setting back to NR
PS Added a tiny change to UpdateProcessor which slipped away from the π Replace REQUEST_TIME in services Fixed . I think this is a better place than other open issues
- Status changed to RTBC
10 months ago 4:34pm 13 February 2024 - Issue was unassigned.
- Status changed to Needs work
10 months ago 4:05pm 16 February 2024 - π¬π§United Kingdom catch
Went to commit this but it needs a rebase for phpstan-baseline.neon
- Status changed to RTBC
10 months ago 4:37pm 16 February 2024 - π³π±Netherlands spokje
Rebase only (with a PHPStan baseline run), so back to RTBC
- Status changed to Fixed
10 months ago 5:28pm 16 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.