[PP-1] Add validation constraints to claro.settings

The config should be updated at the source of the problem here, which is in shortcut.schema.yml

Prashant.c → made their first commit to this issue’s fork.

1. Added mapping for third_party_settings in claro.schema.yml
2. Executed ddev drush config:inspect --filter-keys=claro.settings --detail --list-constraintsgave all keys validated.

➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ----------------------------------------------------------- --------- ------------- ------ ------------------------ 
  Key                                                         Status    Validatable   Data   Validation constraints  
 ----------------------------------------------------------- --------- ------------- ------ ------------------------ 
  claro.settings                                              Correct   100%          ✅✅   ValidKeys: '<infer>'    
   claro.settings:                                            Correct   Validatable   ✅✅   ValidKeys: '<infer>'    
   claro.settings:third_party_settings                        Correct   Validatable   ✅✅   ValidKeys: '<infer>'    
   claro.settings:third_party_settings.shortcut               Correct   Validatable   ✅✅   ValidKeys: '<infer>'    
   claro.settings:third_party_settings.shortcut.module_link   Correct   Validatable   ✅✅   ↣ PrimitiveType: {  }   
 ----------------------------------------------------------- --------- ------------- ------ ------------------------ 

Please review.

Thanks!

Should be in shortcut schema, see #2.

But shortcut.schema.yml already has this section:

theme_settings.third_party.shortcut:
  type: mapping
  label: 'Shortcut settings'
  mapping:
    module_link:
      type: boolean
      label: 'Add shortcut link'

Could you please guide here?

Thanks

I looked into this, I see that olivero does this in the same way. I'm not sure how we can tell the third party settings to apply to this.

Since I'm not sure how to proceed here, I asked in slack: https://drupal.slack.com/archives/C2THUBAVA/p1702728107642189

Actually, this should be fixed in the same way as 🐛 olivero.settings config schema is wrong Needs work

okay then I guess, we can follow the same approach based on the conclusion in https://www.drupal.org/project/drupal/issues/3402885 🐛 olivero.settings config schema is wrong Needs work .

This now needs the FullyValidatable constraint to be added to claro.settings. See https://www.drupal.org/node/3404425 → .

This is postponed on https://www.drupal.org/project/drupal/issues/3416178 📌 Add validation constraints to `type: theme_settings` Active , because (amongst other issues) the "favicon" property contains properties that are dependent on the value of "use_default".

@svendecabooter in #13: Yep, you're right — thanks!