Modal dialogs clip content with certain viewport width

Nice! I got first confused by this because jQuery UI has the maxWidth property, but reading the documentation and testing it manually, it doesn't look like it behaves the same as CSS max-width property. Even if a dialog uses the maxWidth property, it needs this bug fix for it to work on all breakpoints. 👍

Can we add test coverage for this in \Drupal\FunctionalJavascriptTests\Dialog\DialogPositionTest?

Question how often could a new character be added to php date?

Did rebase so I could run the test-only feature

There was 1 failure:
1) Drupal\FunctionalJavascriptTests\Dialog\DialogPositionTest::testModalWidthResizing
Failed asserting that 'position: fixed; height: auto; width: 880px; top: 263.319px; left: 0.003125px; z-index: 101;' contains "width: 745".
/builds/issue/drupal-3395590/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:121
/builds/issue/drupal-3395590/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/builds/issue/drupal-3395590/core/tests/Drupal/FunctionalJavascriptTests/Dialog/DialogPositionTest.php:94
/builds/issue/drupal-3395590/vendor/phpunit/phpunit/src/Framework/TestResult.php:728
FAILURES!
Tests: 2, Assertions: 16, Failures: 1.

Nice test case!

Tested manually and got the same results as the IS.

Realized that we need to take into account displace offsets too

Testing the MR manually, I realized that we should not take into account the displace when the dialog is modal because modal would render on top of other elements. You can check if the dialog is modal from event.data.settings.modal. Maybe we could take that into account in the width calculation and open a follow-up to fix this for the height?

Retested and still see the issue has been fixed. Didn't upload screenshots as the IS has them.

Added few comments in the MR

Why we cannot use css max-width here?
With combination with `calc` and `vw` and `--drupal-displace-offset-left/right`?

This fix is working.
Can be also added

max-width: calc(100vw - var(--drupal-displace-offset-left, 0) - var(--drupal-displace-offset-right, 0)) 

for non modals. Ideally we need to simplify dialog js instead of make it more complicated.

Believe there is 1 thread unanswered. If I'm wrong can a comment be dropped on the thread.

Is the test coverage enough for testing the changes that we implemented.Is it worth adding a test coverage testing the width of a non modal dialog which takes the offset into account as well?

Seems like a random test failure related to chromedriver version.

Believe feedback has been addressed, and issue appears to still be resolved followed same steps as before.

There were test failures related to off-canvas modals so i have fixed those.So marking it needs work until everything is green.

The test are passing to marking it as NR.

Could of sworn tests were green but update didn't break anything.

Works as expected, good work 🎉 , tested manually, have some questions about the test and some nits.

Have some suggestions regarding the documentation otherwise looks good to me.

Added couple of feedback. Not strict but can you review please?