Use type-hinting on deprecation warnings for deleteRevision() introduced by mglaman/phpstan-drupal:1.2.0

Tried to follow https://www.drupal.org/about/core/policies/core-change-policies/drupal-d... → in \Drupal\node\Form\NodeRevisionDeleteForm::__construct, but am _very_ unsure if I understood/did that correctly in the MR.

There might be a follow-up issue in here to tighten the $node_storage argument in the __construct()s of all \Drupal\node\Form\NodeRevision[Whatever]Forms from \Drupal\Core\Entity\EntityStorageInterface to \Drupal\Core\Entity\RevisionableStorageInterface.

So searching for "Call to deprecated method deleteRevision" found 2 other instances

path: modules/field/tests/src/Kernel/FieldAttachStorageTest.php
path: tests/Drupal/KernelTests/Core/Entity/RevisionableContentEntityBaseTest.php

Know these are tests but could we replace them too?

This issue should leave two of the above mentioned deprecation suppressions in the baseline, these are handled in #3383513: Use type-hinting on deprecation warnings for loadRevision() introduced by mglaman/phpstan-drupal:1.2.0

From the IS, those are the two deprecation suppressions mentioned in #8.

Back to NR

Ah sorry missed that. In that case this looked good.

Committed/pushed to 11.x, thanks!

Spokje → closed merge request !4658

Automatically closed - issue fixed for 2 weeks with no activity.