Scrolling remains disabled after closing nested modal dialogs

This might be something worth writing a test for. Here's a fix for this.

For CC failure.

Anyway to add a test?

Fixed custom command failure, keeping NW for tests

After patch

Cannot reproduce the bug in 11.x seems to be fixed in https://www.drupal.org/project/drupal/issues/2707291 🐛 Disable body-level scrolling when a dialog is open as a modal Fixed ?

Thank you for working on this but told per etiquette shouldn’t assign tickets to yourself unless a maintainer.

Simple comment that you’re working on it should be good.

Please see comment #11 here’s a link too for Drupal etiquette https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →

Thanks

thanks, Working on it now.

It looks like the test is passing locally even without the fix.

I'm also wondering if \Drupal\Tests\views_ui\FunctionalJavascript\DisplayTest is the best class to include this. Maybe \Drupal\Tests\views_ui\FunctionalJavascript\AdminAjaxTest would be a better fit?

Tested this locally and the body is scrollable once the dialog is closed.Also it has the test coverage so removing the tags now.Marking it RTBC.

lauriii → closed merge request !4520

Committed a5cd2d7 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.