- Issue created by @lauriii
- Status changed to Needs review
about 1 year ago 1:23pm 29 July 2023 - last update
about 1 year ago Custom Commands Failed - ๐ซ๐ฎFinland lauriii Finland
This might be something worth writing a test for. Here's a fix for this.
- Status changed to Needs work
about 1 year ago 9:36pm 30 July 2023 - ๐ฎ๐ณIndia Gauravvv Delhi, India
Fixed custom command failure, keeping NW for tests
After patch
- last update
about 1 year ago 29,908 pass - Assigned to omkar.podey
- last update
about 1 year ago 29,911 pass - @omkarpodey opened merge request.
- Issue was unassigned.
- ๐ฎ๐ณIndia omkar.podey
Cannot reproduce the bug in 11.x seems to be fixed in https://www.drupal.org/project/drupal/issues/2707291 ๐ Disable body-level scrolling when a dialog is open as a modal Fixed ?
- Assigned to omkar.podey
- Issue was unassigned.
- ๐บ๐ธUnited States smustgrave
Thank you for working on this but told per etiquette shouldnโt assign tickets to yourself unless a maintainer.
Simple comment that youโre working on it should be good.
- Assigned to omkar.podey
- Issue was unassigned.
- ๐บ๐ธUnited States smustgrave
Please see comment #11 hereโs a link too for Drupal etiquette https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... โ
Thanks
- last update
about 1 year ago 29,947 pass - Status changed to Needs review
about 1 year ago 10:44am 2 August 2023 - Status changed to RTBC
about 1 year ago 3:38pm 2 August 2023 - last update
about 1 year ago 29,947 pass - last update
about 1 year ago 29,954 pass - last update
about 1 year ago 29,954 pass - last update
about 1 year ago 29,087 pass, 58 fail - last update
about 1 year ago 29,959 pass - Status changed to Needs work
about 1 year ago 9:00am 14 August 2023 - ๐ซ๐ฎFinland lauriii Finland
It looks like the test is passing locally even without the fix.
I'm also wondering if
\Drupal\Tests\views_ui\FunctionalJavascript\DisplayTest
is the best class to include this. Maybe\Drupal\Tests\views_ui\FunctionalJavascript\AdminAjaxTest
would be a better fit? - Assigned to omkar.podey
- last update
about 1 year ago CI aborted - last update
about 1 year ago 29,972 pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 10:29am 17 August 2023 - Status changed to RTBC
about 1 year ago 10:50am 17 August 2023 Tested this locally and the body is scrollable once the dialog is closed.Also it has the test coverage so removing the tags now.Marking it RTBC.
- last update
about 1 year ago 29,978 pass - last update
about 1 year ago 29,978 pass -
lauriii โ
committed a5cd2d7a on 11.x
Issue #3377900 by omkar.podey, lauriii, Gauravvvv, Utkarsh_33: Scrolling...
-
lauriii โ
committed a5cd2d7a on 11.x
- Status changed to Fixed
about 1 year ago 9:06pm 17 August 2023 Automatically closed - issue fixed for 2 weeks with no activity.