Make DebugClassLoader ignored deprecations more accurate

hmm when we added this, Symfony was triggering this message for all sorts of code that had no intention of adding a return type hint, just because it had @return docblock. So I am a bit surprised that there are so few explicit ones needed now. But... maybe there's been an upstream change, and we can always change things to make them a bit looser again.

#5 yeah my point here is that it is currently so loose we do not really know what's going on with specific dependencies. So here it's tightening, and in individual followups try to fix each dependency by removing their ignores only.

in individual followups try to fix each dependency

I think this will be hard for some - Symfony adds the warning only based on documentation, there is no extra flag to trigger a deprecation error - i.e. it's not like the commented out method parameters where you have to do something explicit. This was by design on their part to essentially nudge everyone into using strict return types, but it's very annoying.

However we might still be able some individual messages, even if it means adding return type hints to our own code that aren't already added in upstream code, so yeah worth a try.

If I'm understanding correctly from the conversation this has sign off. Should follow ups be opened before merging or handled as they come up?

Overall I think this is a good change and tightens up our code; we should be adding types everywhere anyway! We should add these return types in followups, even if upstream has no intention of actually doing so. The Behat, Composer and Doctrine cases should be trivial as it seems unlikely anyone is extending these in custom code.

Twig is more likely to add the types in future, and probably needs a bit more thought - we might have to suppress the deprecation for some specific core classes and let the deprecation cascade to downstream users, and then add the return types finally in Drupal 11?

Yeah I think it's worth adding what we can and worst case we end up with a shorter list, best case an empty list.

IMHO, it's good to have an explicit list, since that would highlight changes occurring to more dependencies should they come. But I am a bit scared on jumping and trying to fix them (well, maybe apart from the PHP ones), since they are only based on interpreting @return annotations upstream: if we lock that in our typehints, and later for any reason dependencies change it to anything else (which could happen), then we may end up in TypeErrors.

I'm triaging RTBC issues → .

I didn't find anything here that needs work, leaving at RTBC.

Committed c5b3bf7 and pushed to 11.x. Thanks!

mondrake → closed merge request !4489

Automatically closed - issue fixed for 2 weeks with no activity.