Prepare FormBuilder for variadic functions

Looks a good place to apply variadics!

It could use CR to notify module developers

This looks like a good plan to me, and good to start using this technique for other issues eventually too.

Thanks @catch and @andypost

Moving to NW for the change record mentioned in #3

Can mark after that.

Changed to MR worflow.

Did not mean to change status.

Added draft CR, https://www.drupal.org/node/3376455 →

+++ b/core/.deprecation-ignore.txt
@@ -10,12 +10,15 @@
+%FormBuilder::getForm\(\).* will require a new "mixed \.\.\. \$args" argument in the next major version of its interface%
+%FormBuilder::submitForm\(\).* will require a new "mixed \.\.\. \$args" argument in the next major version of its interface%

Does the class name need to be fully qualified here?

In the case that someone has extended FormBuilder as \Drupal\custom_module\FormBuilder and swapped it in, I think this will match and accidentally skip the deprecation? We don't always add tests for this sort of thing any more, but this is new (to us) so maybe we should here.

Done

With CR added think this is good to add for 10.2

Committed 29dc14b and pushed to 11.x. Thanks!

Also published the change record. This seems to be the only sane way to add new arguments to interfaces, so let's hope we don't run into any problems with it.

mondrake → closed merge request !4455

Hi 👋
If the deprecation is ignored, will contrib and custom projects see it?

Thanks

#17 well for sure if a custom/contrib class implements the interface, without the to-be signature, then the DebugClassLoader will throw the deprecation.

What I'm not sure about is what happens when a custom/contrib class extends a base class (e.g. Drupal\Core\Form\FormBuilder).

Re #18, it looks like that works. See test patch attached.

thanks!

That's why I asked for the fully qualified class name in #11, as we can't implement this change in the core implementation yet, but all other users of the interface should be notified.

Filed 📌 Make DebugClassLoader ignored deprecations more accurate Fixed for a possible follow-up.

I missed the last week of progress here, but really nice to see this land and the first ever time we've been able to do this with the debug classloader doing what it's supposed to do!

Automatically closed - issue fixed for 2 weeks with no activity.