Fix PHPStan error in run-tests.sh

For some reason I can reproduce this on my core commit checkout, but not on the separate checkout I use for development work, and I am really not sure why.

I had not run composer install on one copy since 📌 Bump phpstan/phpstan and mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again Fixed , so this must be a recent fix in PHPStan or phpstan-drupal.

The attached patch ensures PHPStan runs on all the .sh scripts in the scripts directory, and should trigger the error.

Needs work to fix that method call.

Seems like a simple cleanup.

Committed cb850c3 and pushed to 11.x. Thanks!

Since this commit I am getting errors like this on .inc files when running commit-code-check --cached .

Running PHPStan on changed files.
 ------ --------------------------------------------------- 
  Line                                                      
 ------ --------------------------------------------------- 
  285    Function t invoked with 2 parameters, 1 required.  
 ------ --------------------------------------------------- 

When I revert the commit I do not get the above error message.

Setting back to Needs work for now.

I changed commit-code-check.sh so that PHPSTAN_DIST_FILE_CHANGED=1 and thus phpstan is run on all files. I then get the same error as above but on many files, *.php, *.module, *.inc, *.theme.

Add a dot to sh in the FileExtensions seems to be working as expected.

  fileExtensions:
    - .sh

With that I am not getting the error on either a full run or just the cached files. Maybe the phpstan docs are wrong?

I am still having the problem mentioned above but so far, no one else has reported they also have it. I have opened a new issue 🐛 Remove redefintion of t() from update-countries.sh Fixed . I'll set this back to Fixed.

Automatically closed - issue fixed for 2 weeks with no activity.