Contrib.social

Bump phpstan/phpstan and mglaman/phpstan-drupal to latest to make daily "updated deps" QA run pass again

Open on Drupal.org →
Created on 6 July 2023, 12 months ago
Updated 23 July 2023, 11 months ago

Problem/Motivation

PHPStan released version 1.10.24 (See https://github.com/phpstan/phpstan/releases/tag/1.10.24).

After numerous worry-free updates this one uncoveres previously unspotted Level 1 issues.

NOTE: Updating mglaman/phpstan-drupal is necessary, because without that we get 14 errors on 10.1.x and 17 on 11.x.
See here 📌 [Ignore] In space (and/or this issue), no one can hear patches scream VII Closed: outdated and here 📌 [Ignore] In space (and/or this issue), no one can hear patches scream VII Closed: outdated .

Steps to reproduce

See https://www.drupal.org/node/3060/qa → and notice the failures on updated deps jobs for 11.x.

Proposed resolution

- Upgrade phpstan/phpstan to 1.10.24
- Upgrade mglaman/phpstan-drupal to 1.1.36
- Create a new baseline
- Bump versions of phpstan/phpstan and mglaman/phpstan-drupal in composer.* to latest, since the newly created baseline won't pass on any lower version.

Sadly the two newly discovered errors are for 📌 Fix PHPStan L1 errors "Call to method getDefinitions()/getSortedDefinitions() on an unknown class Drupal\Core\Plugin\CategorizingPluginManagerTrait." Needs work , which is postponed on other issues and, most importantly a change/update/something on our deprecation policy ( 🌱 Document how to add additional parameters to interface methods Fixed ), so for now, we can't fix it immediately.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task
Status

Fixed

Version

11.0 🔥

Component
PHPUnit  →

Last updated less than a minute ago

Created by

🇳🇱Netherlands Spokje

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024