Fix PHPStan L1 errors "Call to method foo() on an unknown class Bar\Baz."

Left a comment in the MR. Can you help me understand @Spokje?

@mondrake: Tried a (weak) explanation in the MR thread.

Comment in MR, thanks!

@mondrake Makes sense, will change it shortly.

If it turns out to be too much we can always revert to the "minimal" working cas at https://git.drupalcode.org/project/drupal/-/merge_requests/3794/diffs?co...

BTW: is the issue still accurate?

BTW: is the issue title still accurate?

You're right, we can be more specific here.

Ok, let's give this a new NR round :)

To me, this is the cleanest way to fix this mess…

Adding an argument to the interface is not backward compatible with any existing implementations, and there are a handful in contrib at least:

http://grep.xnddx.ru/search?text=getSortedDefinitions&filename=

I have opened 🌱 Document how to add additional parameters to interface methods Fixed to discuss how to manage cases where interfaces are wrong and we cannot change them

And another PHPStan issue grinds to a halt, postponing on 🌱 Document how to add additional parameters to interface methods Fixed

Looking for 📌 Replace func_get_args with variable-length argument in FormBuilder Needs review to go in, that sets a reference for prepping the addition of arguments to interface methods, and this could follow.

Typehinting of return type follows the covariance rules https://www.php.net/manual/en/language.oop5.variance.php, so adding one to the interface means BC break because implementing classes must at least implement the same return type.

How to change signatures in interfaces has been documented: 🌱 Document how to add additional parameters to interface methods Fixed

Traits can have abstract methods, if we do that we can remove the @var and it seems happy enough? See MR!10468.

Nice! I was not aware of the abstract methods approach but will be remembering it. Change appears pretty straight forward and addresses the task. LGTM

Committed to 11.x thanks!

larowlan → closed merge request !3794

larowlan → closed merge request !10468