- Issue created by @Harshita mehra
- Status changed to Needs review
over 1 year ago 10:57am 18 July 2023 - ๐ฎ๐ณIndia Harshita mehra
I have provided a patch to fix this issue.
Please review it. - Status changed to RTBC
over 1 year ago 2:19pm 18 July 2023 - ๐ต๐ญPhilippines clarkssquared
Hi Harshita mehna
I applied your patch #2 to my local and I confirmed that your patch fixed all the PHPCS errors.
please look at the screenshot I attached for your reference
Thank you
- Status changed to Needs work
over 1 year ago 9:25am 20 July 2023 - ๐ฎ๐นItaly apaderno Brescia, ๐ฎ๐น
/** - * Class LazyConfigForm. + * Class of LazyConfigForm. */
The description is still just repeating the class name; adding of, apart from not be correct, does not change that.
- Status changed to Needs review
over 1 year ago 5:19am 25 July 2023 - ๐ฎ๐ณIndia mrinalini9 New Delhi
Updated patch #2 by addressing #8, please review it.
Thanks!
Hi, Reviewed the patch #9, applied cleanly but still shows some errors after applying patch.
- ๐ฎ๐ณIndia dev16.addweb
silvi.addweb โ made their first commit to this issueโs fork.
- Status changed to RTBC
3 months ago 12:59pm 9 August 2024 - ๐ต๐ญPhilippines cleavinjosh
Hi @silvi.addweb,
I applie MR!1, it was applied smoothly and fixed the phpcs issues.
โ lazy_config_form git:(51d29d1) curl https://git.drupalcode.org/project/lazy_config_form/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 1607 0 1607 0 0 4394 0 --:--:-- --:--:-- --:--:-- 4402 patching file lazy_config_form.module patching file src/Form/LazyConfigForm.php โ lazy_config_form git:(51d29d1) โ .. โ contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml lazy_config_form โ contrib
Thank you.