Fix deprecated overloaded function usage in PHP 8.3

It should wait for the first beta of 8.3 (in 1 week) but suppose following patch

The ReflectionMethod deprecations should be delayed until 8.4 so version check could be added. Before that it makes no sense to slowdown the method

+++ b/core/lib/Drupal/Component/Plugin/PluginManagerBase.php
@@ -125,7 +125,7 @@ protected function handlePluginNotFound($plugin_id, array $configuration) {
-    throw new \BadMethodCallException(get_class() . '::getFallbackPluginId() not implemented.');
+    throw new \BadMethodCallException(self::class . '::getFallbackPluginId() not implemented.');

probably it could use separate issue to improve the message like self::class ... is not implemented in ... static::class

📌 Introduce CallableResolver to help standardise the DX and error handling for callbacks across various subsystems Fixed added the ReflectionMethod call to 11.x so its not even in php's audit. Neat!

> it makes no sense to slowdown the method
Since we bypassed the audit, should we raise that slowdown concern with the PHP mailing list? I expect with symfony, laminas, and nette in their list some form of "if you expect reflection to be fast you're doing it wrong" response which is probably accurate but maybe.

Sample implementation post deprecation for reference:

    // Optimized for arrays over strings.
    if (is_array($callable)) {
      return new \ReflectionMethod($callable[0], $callable[1]);
    }
    if (is_string($callable) && str_contains($callable, '::')) {
      $callable = explode('::', $callable, 2);
      return new \ReflectionMethod($callable[0], $callable[1]);
    }
    return new \ReflectionFunction($callable);

+++ b/core/lib/Drupal/Component/Plugin/PluginManagerBase.php
@@ -125,7 +125,7 @@ protected function handlePluginNotFound($plugin_id, array $configuration) {
-    throw new \BadMethodCallException(get_class() . '::getFallbackPluginId() not implemented.');
+    throw new \BadMethodCallException(self::class . '::getFallbackPluginId() not implemented.');

Don't we need static:: to get that sweet LSB to make it actually useful? Interesting that this passed testing...

Don't we need static::

Using Google's Bard the suggested change is

protected function getFallbackPluginId($plugin_id, array $configuration = []) {
throw new \BadMethodCallException(static::class . '::getFallbackPluginId() not implemented. This method must be implemented in order to use the fallback plugin.');
}

Interesting that this passed testing...

Because there's no coverage for the method( Sounds like needs separate issue

One more RFC landed https://wiki.php.net/rfc/saner-inc-dec-operators

Seems like a simple enough change.

Feel this conversation was just had about sections that never had testing, if they belong in follow ups or not.

Think with a change this small moving the testing to a follow up wouldn't be a problem.

Maybe we open a Meta for extended test coverage for items that must be included in D11. So pushing testing to follow ups don't just hang there.
May be a thread on slack conversation though.

This week the beta 1 will out and I bet we'll need to split assertion and new deprecations

The issue summary appears to be talking about more changes than the patch. The changes in the patch look fine, but I don't understand the mismatch.

Filed separate issue for assertions 📌 Fix deprecated assert_options() function usage for PHP 8.3 Needs review as they are blocking linker now

Checking on beta1 and found that

/var/www/html/web $ php -v
PHP 8.3.0beta1 (cli) (built: Jul 18 2023 23:53:10) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.3.0-dev, Copyright (c) Zend Technologies
    with Zend OPcache v8.3.0beta1, Copyright (c), by Zend Technologies
    with Xdebug v3.3.0-dev, Copyright (c) 2002-2022, by Derick Rethans

Reflection method is not deprecated yet but I added a fix (#5 suggested a bit different from the RFC)
the new createFromMethodName() method is added

/var/www/html/web $ php -r 'class aa { function b() {}}; var_dump(new ReflectionMethod(...explode("::", "aa::b")));'
object(ReflectionMethod)#1 (2) {
  ["name"]=>
  string(1) "b"
  ["class"]=>
  string(2) "aa"
}
/var/www/html/web $ php -r 'class aa { function b() {}}; var_dump(new ReflectionMethod("aa::b"));'
object(ReflectionMethod)#1 (2) {
  ["name"]=>
  string(1) "b"
  ["class"]=>
  string(2) "aa"
}
/var/www/html/web $ php -r 'class aa { function b() {}}; var_dump( ReflectionMethod::createFromMethodName("aa::b"));'
object(ReflectionMethod)#1 (2) {
  ["name"]=>
  string(1) "b"
  ["class"]=>
  string(2) "aa"
}

setValue() now throws

/var/www/html/web $ php -r 'class aa { public static $a; }; var_dump((new ReflectionProperty("aa", "a"))->setValue(null, null));'
NULL
/var/www/html/web $ php -r 'class aa { public static $a; }; var_dump((new ReflectionProperty("aa", "a"))->setValue(null));'
PHP Deprecated:  Calling ReflectionProperty::setValue() with a single argument is deprecated in Command line code on line 1

Deprecated: Calling ReflectionProperty::setValue() with a single argument is deprecated in Command line code on line 1
NULL

get_class() throws, so replaced with static:: as implementation should live in called class

/var/www/html/web $ php -r 'class aa { static function b() { var_dump(get_class()); } } aa::b();'
PHP Deprecated:  Calling get_class() without arguments is deprecated in Command line code on line 1

Deprecated: Calling get_class() without arguments is deprecated in Command line code on line 1
string(2) "aa"

+++ b/core/lib/Drupal/Component/Utility/ArgumentsResolver.php
@@ -123,7 +123,7 @@ protected function getReflector(callable $callable) {
-      return new \ReflectionMethod($callable);
+      return new \ReflectionMethod(...explode('::', $callable));

asked about it https://github.com/php/php-src/pull/11703#discussion_r1268709319

The last submitted patch, 12: 3374223-12.patch, failed testing. View results →

Random failure

+++ b/core/lib/Drupal/Component/Plugin/PluginManagerBase.php
@@ -125,7 +125,7 @@ protected function handlePluginNotFound($plugin_id, array $configuration) {
-    throw new \BadMethodCallException(get_class() . '::getFallbackPluginId() not implemented.');
+    throw new \BadMethodCallException(static::class . '::getFallbackPluginId() not implemented.');

this message is not covered with test as no test failed in #3375693-5: Fix deprecated assert_options() function usage for PHP 8.3 →

IS seems to be updated so remarking.

Removed hunk for ArgumentsResolver because misread RFC https://github.com/php/php-src/pull/11703#discussion_r1269355095

This RFC proposes to add the following new factory method in PHP 8.3 and deprecate the second constructor signature in PHP 8.4. Finally, the deprecated signature would become unsupported in either PHP 9.0 or 10.0

updated IS a bit

The last submitted patch, 19: 3374223-19.patch, failed testing. View results →

PathWorkspacesTest again

The last submitted patch, 19: 3374223-19.patch, failed testing. View results →

Back to RTBC

Backported to 10.1.x as a low risk bug fix to help keep the branches in sync.

Committed and pushed 4912be319e to 11.x and d12b95d2c8 to 10.1.x. Thanks!

Tests revealed 2 more #3375693-16: Fix deprecated assert_options() function usage for PHP 8.3 →

Automatically closed - issue fixed for 2 weeks with no activity.

Filed follow-up 📌 Fix deprecated ReflectionProperty::setValue() usage for PHP 8.3 Needs review

There's a get_class deprecation in Core/Render as well, see 🐛 Calling get_class() without arguments is deprecated in Drupal\Core\Render\ElementInfoManager Active