Views: "More link" URL contains exposed filter parameters when using the "Custom URL" option

Test should check the actual full url. This could still have the parameters and be passing.

Updated the tests.

With a standard install
Created a block off the Content view
Set the more link to always show
Placed in the content region of the olivero theme
Verified the link has the filter parameters on it

Applied patch

Parameters are gone.

1. +++ b/core/modules/views/tests/src/Functional/Plugin/DisplayTest.php
   @@ -20,7 +20,7 @@ class DisplayTest extends ViewTestBase {
   +  public static $testViews = ['test_filter_groups', 'test_get_attach_displays', 'test_view', 'test_display_more', 'test_display_invalid', 'test_display_empty', 'test_exposed_relationship_admin_ui', 'test_simple_argument', 'test_exposed_block'];
   

   Why does this need another view? Can't the existing view, test_display_more, be modified? If it can't then I think the comment on the test should explain why a 'block' view is needed instead of the view for testing the more linke.

This seems like a nice improvement. Thanks for the issue and patch.

2. +++ b/core/modules/views/tests/src/Functional/Plugin/DisplayTest.php
   @@ -294,6 +294,20 @@ public function testReadMoreCustomURL() {
   +    // Verify that the more link doesn't contain any exposed filter parameter.
   

   I am not an expect on grammar but this reads wrong to me. So I used an on-line checker and yes this needs a tweak.
   And when we are adding to a method or file it is best to use the same style of the existing comments in this method. It just helps future readers of the file. Something along the lines of
   // Test more link omits filter parameters.

Tried to address the pointer 2 in #8.
Please review.

@quietone addressed both points from #8

The settings for Link Display only appears for view blocks and not pages. So that's why test_exposed_block is used.

Why is this a bug? I’m sure there are scenarios where you don’t want this data added by are we sure we are not breaking other scenarios where you do want it?

After discussion with @lendude in @bugsmash on slack. Moving this to a Feature request to add an option to not add the exposed data. Code was purposely added in https://www.drupal.org/node/564106 → so don't want to just undo that. Also opened https://www.drupal.org/project/drupal/issues/3386511 📌 Extend test coverage for DisplayTest::testReadMoreCustomURL RTBC for a follow up to expand test coverage