Extend test coverage for DisplayTest::testReadMoreCustomURL

Lendude → credited ranjith_kumar_k_u → .

✨ Views: "More link" URL contains exposed filter parameters when using the "Custom URL" option Needs work showed that we can remove the logic for adding exposed filter data and this leads to no test failures, hence we are missing this coverage.

Since we are explicitly adding this data in \Drupal\views\Plugin\views\display\DisplayPluginBase::getMoreUrl we should add a test case that makes sure this doesn't regress.

This adds that test, crediting @ranjith_kumar_k_u for writing it in ✨ Views: "More link" URL contains exposed filter parameters when using the "Custom URL" option Needs work , I just updated it to check that this data does get added instead of the original that checked that it shouldn't get added

all green

Thanks for moving this to a separate issue.

1. +++ b/core/modules/views/tests/src/Functional/Plugin/DisplayTest.php
   @@ -294,6 +294,20 @@ public function testReadMoreCustomURL() {
   +    $this->drupalCreateContentType(['type' => 'article']);
   

   This looked odd to me. I tested without the article content type and the test passes. So, this can be removed.

2. +++ b/core/modules/views/tests/src/Functional/Plugin/DisplayTest.php
   @@ -20,7 +20,7 @@ class DisplayTest extends ViewTestBase {
   +  public static $testViews = ['test_filter_groups', 'test_get_attach_displays', 'test_view', 'test_display_more', 'test_display_invalid', 'test_display_empty', 'test_exposed_relationship_admin_ui', 'test_simple_argument', 'test_exposed_block'];
   

   Since there is already a change to make, let's make this array multi-line and easier to read.

Addressed feedback from #5

Feedback has been addressed

The last submitted patch, 6: 3386511-6.patch, failed testing. View results →

Seems random.

The last submitted patch, 6: 3386511-6.patch, failed testing. View results →