- Issue created by @cosmicdreams
- 🇺🇸United States volkswagenchick San Francisco Bay Area
I have seen this demo'ed at various stages of development and am impressed.
I think Content Creators and Editors will find this very useful. I find Same Page Previews has better usability than the preview currently available in core. I think this aligns with the "ambitious site builder" experience.Thanks for the speedy work on this useful module.
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
I've updated our module page to reflect the current state of the module. I suppose I should also work on what a commit to the 11.x branch might look like to give folks here something to critque.
- 🇸🇪Sweden johnwebdev
+1 on this aligns with the "ambitious site builder" experience.
+1 for same page preview in core! It's one of those things that seem required once when you see it in action. Bravo for the job done so far!
- 🇸🇮Slovenia boshtian
Inline editor was added to core in the past but didn't succeed. I think one of the reasons was, that people were not used to inline editing and also the frontend themes were often broken when inline forms were added to markup.
Instant (same page) preview is something that cloud CMS's are selling as a feature and I also think that it has much better chance of succeeding in core than Inline editor.
+1 from me to add this to core in light of "ambitious site builder" experience.
- 🇬🇧United Kingdom SirClickALot Somerset
A very BIG +1 from me; this is precisely the kind of thing we need to promote Drupal
Into core ASAP I say!
I've done a very quick test with:
- Drupal 10.1.6
- PHP 8.1.0
- Theme: Bootstrap 5 → subtheme 3.0.10
- Admin theme: Gin 8.x-3.0-rc7 →
Note sure about these enormous buttons, but maybe that's just a Bootstrap 5 / Gin combo thing...
Great work team!
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Thanks for the excellent bug report!
We might need to provide better protection of our elements to ensure that our buttons aren't impacted by administrative themes.
I'm eager to have time to fix this but am under a terrible crunch right now. I should have time in a few weeks to fix.
- 🇩🇰Denmark ressa Copenhagen
+1 for adding to Drupal core! I am very impressed, this looks awesome, and it would be a huge improvement for the Ambitious Site Builder.
- 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
Yes, huge +1.
This would be a fantastic addition to the Drupal content editorial experience. I've been aware of this, but I just wanted the video on the project page to get a proper understanding of how it works, and I think this is something that I know the content designers I work with would love.
One thing that comes to mind for consideration, and I expect these are already being considered or have been worked on, but wanted to raise them here for the record: How well does this work on small screens and mobile? Should we consider more than just a horizontal arrangement.
Either way, looks great, I'm excited for the day this lands in core!
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Next steps:
* Try to get this into some kind of Recipe or Distribution.
* Continue refining / being active in the issue queue.
* Listen to use cases I didn't consider and ensure we can adapt.
* Which means reorganzing my work/life to ensure I can give proper time to this effort (working on that).Timing:
Given my silly desire to use Single Directory Components, perhaps I set back the inclusion of this work a ways since it would depend on another experimental feature. So.... Drupal 10.3+ might be a good target. - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
If Same Page Preview was in core, there would be a number of changes we would do.
- There are number of places we are extending core: NodeForm, PreviewControlsForm. We wouldn't need to do that and instead would refine our overrides further and include them in the Core objects.
- CSS: We've had to include a small amount of changes to styles the we may not need to do if we could teach a future off-canvas dialog how to be resized without artifacts.
- JS: We anticipate that much of the work of including this module into core is going to be spent refining the javascript. There's totally room for improvement. And in a world where experience builder and other dynamic user experience also exist, there's probably a lot of new ways of accomplishing what we're doing.
If it helps, we could produce an MR that would show what including this into core would look like.
- 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
Given the changing landscape of Drupal recently, could Same Page Preview be added to Starshot, that seems like a good option, then decide whether it needs to be in "Core" beyond that.
- 🇺🇸United States brianperry
@AaronMcHale there is actually an issue and a related PR in the Starshot prototype repo:
https://github.com/phenaproxima/starshot-prototype/issues/17
https://github.com/phenaproxima/starshot-prototype/pull/61 - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
As @brianperry has shown, yes. And we agree that's a great first step.
It should be noted, that the Next Steps are still on the Same Page Preview team.
We need to demonstrate what the actual change would be to include this into core. That said, before Starshot, the typical first step would be to be included as an experimental module. And for that step, same_page_preview would likely change very little. We do anticipate some change due to feedback / core contributor's direction. Fundamentally thought, we've already tried to only use core and to do as little as possible.
But if this work was in core, some obvious changes would be made. Such as:
- No longer need to extend @internal objects
- spread our logic to existing administrative forms
- As a result, probably won't need to any any new objects, forms, or other objects. Just extend existing ones with additional logic.
In addition, I'm personally very excited about the new navigation bar and the top navigation bar specifically. We have an excellent opportunity to demonstrate the utility of both with our preview pane. Eager to learn more about making use of it.
