Deprecate NodePreviewController::title

Confirmed this is still an issue. HtmlRenderer::prepare only calls the title resolver if #title isn't set. This gets set on the preview route by a #pre_render in EntityViewController::buildTitle

Makes sense to me. Fine given the change record already exists, for *me*, this one falls in a category of just the issue being sufficient, similar to constructor changes. There is a very good chance this impacts literally 0 sites.

Committed/pushed to 11.x, thanks!

catch → closed merge request !11774

I confirmed with catch that the CR is not needed. I have changed the title and I will delete it later.

Ok thanks, how do we determine if a deprecation doesn't need a CR?

@acbramley it's hard to decide and I think we frequently get it wrong in both directions. For me if it's pure deprecation of @internal code, especially when we think that code is dead or not interacted with (in any sense) by contrib, we should skip it.

@acbramley, This policy doc → is for explaining when to write a change record.