- Issue created by @lauriii
- Status changed to Needs review
over 1 year ago 9:26am 14 June 2023 35:04 29:56 Running- Status changed to RTBC
over 1 year ago 2:32pm 14 June 2023 - ๐บ๐ธUnited States smustgrave
Tested out on 11.x following the screenshots in the issue summary.
Confirmed the translate modal popups as described. Looks good - ๐ฎ๐ณIndia narendraR Jaipur, India
Found a small nit.
+++ b/core/modules/config_translation/tests/src/FunctionalJavascript/ConfigTranslationUiTest.php @@ -43,4 +44,35 @@ public function testViewContextualLink() { + * Tests that config translation add and edit operation opens in a modal.
add and edit ==> add, edit and delete
- last update
over 1 year ago 29,476 pass - last update
over 1 year ago 29,500 pass - ๐ฎ๐ณIndia rajeshreeputra Pune
@lauriii, @smustgrave tested the patch on 11.x this gives really good feel while translation. My question here is why not to include it in D10.1.x?
- last update
over 1 year ago 29,500 pass Ahmad Smhan โ made their first commit to this issueโs fork.
- ๐บ๐ธUnited States bnjmnm Ann Arbor, MI
Re #5 @Rajeshreeputra:
e tested the patch on 11.x this gives really good feel while translation. My question here is why not to include it in D10.1.x?
Unless a change is meant only for a specific branch, we work on the highest-numbered dev branch first, then backport to earlier versions. So in this case we are working on 11.x, and when it is committed to 11.x it will also be backported to the 10.x dev branch(es) permitted by the backport policy โ
-
bnjmnm โ
committed d3a1923f on 11.x
Issue #3366676 by lauriii, smustgrave, narendraR: Display config...
-
bnjmnm โ
committed d3a1923f on 11.x
- Status changed to Downport
over 1 year ago 6:25pm 21 June 2023 - Status changed to Fixed
over 1 year ago 6:45pm 21 June 2023 - ๐บ๐ธUnited States bnjmnm Ann Arbor, MI
Just got confirmation that 10.2 will be cut from 11.x so there's no need to backport. 10.1 is all but released, and this is the sort of change that isn't suitable for a patch release, so this is already complete.
Automatically closed - issue fixed for 2 weeks with no activity.