- Issue created by @andypost
- Status changed to Needs review
over 1 year ago 11:32pm 9 June 2023 - last update
over 1 year ago 29,437 pass - Status changed to RTBC
over 1 year ago 5:02am 10 June 2023 - Status changed to Needs review
over 1 year ago 3:05pm 10 June 2023 - πΊπΈUnited States dww
IMHO, this is masking a bug. Coreβs version string, even in
main
branch when it exists (or 11.x) for now, should never be a 2-digit version. See the branch alias issue. Iβd call this works as designed. - π³π±Netherlands spokje
Seeing that it causes an (uncaught) PHP warning, that (AFAICT) we expect to cause tests to fail ( π TestBot throws uncaught PHP Warning on 11.x-dev only Active ), my humple opinion is that it's broken, which can't be works as designed.
But happy to let other, bigger brains decide on this :)
- πΊπΈUnited States dww
I agree thereβs a problem. My view is the problem comes from using β11.0-devβ as the VERSION string in the branch, not what this test is doing.
- π³π±Netherlands spokje
Absolutely a fair point.
We both agree there's a problem, we just don't agree on the solution.
- Status changed to RTBC
over 1 year ago 5:07pm 15 June 2023 - Open on Drupal.org βEnvironment: PHP 8.2 & MySQL 8last update
over 1 year ago Waiting for branch to pass 49:25 48:59 Running49:03 45:39 Running- π«π·France andypost
Probably it could use better fix but I have no idea how to improve it
- last update
over 1 year ago CI aborted - last update
over 1 year ago CI aborted - π¬π§United Kingdom catch
π Add a branch alias for 11.x Fixed would be the one - if we can resolve that, we might not need the workaround here.
- πΊπΈUnited States dww
But thatβs the point, if VERSION was already 10.2.0-dev in the βmainβ branch, this test wouldnβt have any trouble. 2 is already an int.
- Status changed to Needs review
over 1 year ago 7:44am 16 June 2023 - last update
over 1 year ago 29,473 pass - Status changed to RTBC
over 1 year ago 3:52pm 17 June 2023 - πΊπΈUnited States smustgrave
Seems like a good compromise to me. Unless we ever name the branch "main" right?
- last update
over 1 year ago 29,499 pass - Status changed to Fixed
over 1 year ago 8:49pm 19 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.