- Issue created by @kim.pepper
- First commit to issue fork.
- last update
over 1 year ago Custom Commands Failed - @elber opened merge request.
- Status changed to Needs review
over 1 year ago 1:22pm 5 June 2023 - Status changed to Needs work
over 1 year ago 5:30pm 5 June 2023 - 🇺🇸United States smustgrave
Seems to have CC failure if that can be resolved please.
- last update
over 1 year ago 29,416 pass - Status changed to Needs review
over 1 year ago 6:49pm 5 June 2023 - Status changed to Needs work
over 1 year ago 2:51am 6 June 2023 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Needs work for MR review comments.
- last update
over 1 year ago 29,417 pass - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
over 1 year ago 11:21am 6 June 2023 - 🇧🇷Brazil elber Brazil
Hi the delete function and deleteRecursive function are returning a boolean value instead a void type mentioned in the bitbucket
and then I changed to bool type. Please revise. - last update
over 1 year ago 29,417 pass - Status changed to Needs work
over 1 year ago 11:36am 6 June 2023 - Status changed to Needs review
over 1 year ago 1:26pm 6 June 2023 - 🇧🇷Brazil elber Brazil
Hi I fixed all of them please can you tell me what is wrong?
(Tests are passing)
- 🇬🇧United Kingdom ChrisDarke London
Migrating Pittsburgh 2023 to Pittsburgh2023 tag for cleanup
- Status changed to Needs work
over 1 year ago 11:55pm 6 June 2023 - last update
over 1 year ago 29,420 pass - 🇧🇷Brazil elber Brazil
Hi I just rebased, @kim.pepper please can you tell me the next steps?
- last update
over 1 year ago 29,554 pass - Status changed to Needs review
over 1 year ago 5:34pm 26 June 2023 - Status changed to RTBC
over 1 year ago 7:32pm 26 June 2023 - last update
over 1 year ago 29,562 pass - last update
over 1 year ago 29,566 pass - last update
over 1 year ago 29,571 pass - last update
over 1 year ago 29,801 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,802 pass - last update
over 1 year ago 29,806 pass - last update
over 1 year ago 29,811 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,815 pass - last update
over 1 year ago 29,822 pass - last update
over 1 year ago 29,827 pass - Status changed to Needs review
over 1 year ago 5:57am 21 July 2023 - 🇦🇺Australia dpi Perth, Australia
The proposed changes to date look good.
Can we add detail about the backwards compatibility story to the summary. Do we need a change notice?
We may as well add rich return type detail for
\Drupal\Core\File\FileSystemInterface::scanDirectory
anddoScanDirectory
since this issue is about improving typehints. Either modify@return array
, or if Drupal coding standards do not pass then use@phpstan-return
with something like@phpstan-return array<string, object{uri: string, filename: string, name: string}>
. I believe Drupal CS may still have issues with spaces; remove spaces, it will work just as well. - Status changed to Needs work
over 1 year ago 4:08pm 30 July 2023