"Accordion" display broken due to missing jQuery Accordion dependency

Configuration in the 1st Screenshot looks correct! Can anyone confirm this? Perhaps on a different form or theme?

@anybody, I can confirm. You can easily check it on https://simplytest.me/

Thanks, so someone should find out the reasons and fix it. Thank you!

Hi there,

Need to install module jquery_ui_accordion → bexause now it's contrib module.

@q2_faith: Thank you! That means, to fix this, we should separate the accordion feature into a separate submodule and add a dependency on jquery_ui_accordion module in that submodule (besides field_group dependency).

We should not add that dependency in the field_group module, as it would then require everyone using field_group to also install jquery_ui_accordion, even if not used.
Furthermore, it will need a detection, if a field group accordion is used in the project. If yes, the update hook should enable that submodule.
An alternative would be to enable it by default and inform the user in the update hook, that it can be removed, if not used. But I think that's far less convenient.

As jQuery was removed in Drupal 10, we could discuss creating a separate 4.x branch for that.

Any maintainer feedback on the plan, please?

Interesting, at least in the 8.x-3.x-dev branch the libraries file already contains

formatter.accordion:
  js:
    formatters/accordion/accordion.js: {}
  dependencies:
    - core/jquery
    - core/once
    - jquery_ui_accordion/accordion

while the module file didn't contain that dependency.

I added that dependency in the quickfix branch. Here's the patch, if anyone needs it:
https://git.drupalcode.org/project/field_group/-/merge_requests/35.diff

For the real solution we should now discuss #7 with the maintainers.

I added the module to the test dependency, so it is clear, that this change does NOT lead to failing tests. This can be reverted later, if the maintainer decides to put 'Accordion' in its own submodule.

(Setting this to Needs Review, so this issue becomes more noticable).

Also, there seems to be an incomplete and / or risky test. I created a separate issue for that: 📌 Fix risky test Active .

We should not add that dependency in the field_group module, as it would then require everyone using field_group to also install jquery_ui_accordion, even if not used.

Totally agree.

Interestingly that the module checks this additional module but I don't see any messages.

Oh well, tests still fail, I probably also need to adjust the test module dependencies, but not really worth it, as the location for the accordion will change anyway.

Thanks @q2_faith !!
I have installed module jquery_ui_accordion and now works!

Maybe you could write this in the README.md and in the front page...

Thanks a lot for the module :)

I think accordion should be removed from the module and be in another sub mobule. It's also consufing because "Detail" field group is also like an accordion.

@Grevil The patch seems to solve the issue.

@Anybody, should we merge this then as a quick fix for the time being or properly dissect the module and move the accordion part in its own submodule in this issue?

I personally think that if we moved this functionality away, it will be like we deprecate it since it's been here for years and developers expect it to exist by default with the Field Group module.

Unless you do want to deprecate it; that's another discussion...

This patch adds the jquery_ui_accordion as hard dependency, and that is not what we want.
There is a hook_requirements implementation to warn that you need to install the jquery_ui_accordion module if you want to use accordions.

However, marking it as deprecated is a good solution. As you don't want to use it anymore, since Jquery UI is EOL.
I'll change 2 things:

• Change the requirements implementation to a warning, so it is on top of the reports page. Now it was only an info item
• Add (deprecated) to the name of Accordion and also add a warning on the reports page if you are using this formatter

I went for the submodule approach. That module is now also marked as deprecated and a warning will appear on the reports screen.
An update hook was written to handle the install on existing sites.

Great work @nils.destoop !

Automatically closed - issue fixed for 2 weeks with no activity.