🇧🇾Belarus @q2_faith

Hi there,
MR 5321 works for operator "Is one of" and doesn't work for "Is all of" but at least fixes error

Error: Attempt to assign property "type" on null in Drupal\views\ManyToOneHelper->ensureMyTable() (line 220 of /var/www/html/web/core/modules/views/src/ManyToOneHelper.php).

.
I tried to figured out how to fix it but unsuccessfully. What I did(changes agains patch)

1. Removed
   

   $join = $this->getTableJoin($join->table, $join->leftTable);
   

   in HandlerBase.php in 616 line. I think it isn't necessary to join table one more time because we already did it. Additionally, it doesn't work because the condition

   if (isset($data['table']['join'][$base_table])) {
   

   never returns true in method getTableJoin.

2. The second place where we call method getTableJoin is in ManyToOneHelper.php line 112. On the behalf first point we get here null as well. I added checking on null.
   

   $r_join = HandlerBase::getTableJoin($r_join->leftTable, $base_table);
         if (!$r_join) {
           $r_join = clone $join;
           break;
         }
   

Now query looks properly in Views preview but doesn't return any result. Like,
INNER JOIN {taxonomy_term_field_data} "taxonomy_term_field_data_value_1" ON paragraphs_item_field_data_node__field_xxxx_xxxx__paragraph__field_xxxx_xxxx.field_xxxx_xxxx_target_id = taxonomy_term_field_data_value_1.tid AND taxonomy_term_field_data_value_1.tid = '68'
And, I don't have idea how fix it. I will appreciate for any advice.
Thanks!

Added temporary patch

Additionally to #10 ✨ Allow forms to easily determine whether they are shown in a modal Needs work , when you submit ajax submit , WRAPPER_FORMAT == 'drupal_ajax'. And using this patch breaks the modal form.

We should not add that dependency in the field_group module, as it would then require everyone using field_group to also install jquery_ui_accordion, even if not used.

Totally agree.

Interestingly that the module checks this additional module but I don't see any messages.

Hi there,

Need to install module jquery_ui_accordion → bexause now it's contrib module.

@anybody, I can confirm. You can easily check it on https://simplytest.me/

q2_faith → created an issue.

Hi there,

The main issue can be easily fixed if you extend class RulesConditionBase. But if you use deriver of plugin and in the method getDerivativeDefinitions make static call ContextDefinition::create(). And so to speak, in this case, there are no ways to fix it.

Based on this, I really suggest implementing this fix.

Thanks in advance!

P.S. I found that for 7-x version this approach was used.

This will change 3.6.0 (default jquery version of the site) to 2.2 and empty string (bartiks' setting of "Site Default") to 1.12.

We have such behaviour. A website has "jquery_update_jquery_version" and "jquery_update_custom_version_jquery" that were set by custom paths - 3.5.1. But then, it reverted to 1.12.

Yes, you're right. I faced with the issue in Drupal multisite. Shall I add this information in description and possibly update tests?

q2_faith → created an issue.

Checked the patch. It fixes the issue.
Thank you!