Forms that are intended to be shown in a modal dialog also have a fallback for when javascript is disabled. For example, a "Cancel" button should be shown on the fallback, but not when displayed in a modal.
The information whether a form is displayed in a modal can be found on the request, but this is not very DX friendly and hard to discover:
$this->getRequest()->query->get(MainContentViewSubscriber::WRAPPER_FORMAT) === 'drupal_modal';
Needs work
11.0 🔥
Last updated
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Used to track the progress of issues reviewed by the Drupal Needs Review Queue Initiative.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
protected function isModal()
Should be typehinted
Tests were requested in #2 and #5 which still needs to happen.
And the question in #10 should be addressed.
Additionally to #10 ✨ Allow forms to easily determine whether they are shown in a modal Needs work , when you submit ajax submit , WRAPPER_FORMAT == 'drupal_ajax'. And using this patch breaks the modal form.