- Issue created by @kim.pepper
- Status changed to Needs review
8 months ago 2:07pm 30 October 2023 - last update
8 months ago 30,481 pass - Status changed to RTBC
8 months ago 4:38pm 30 October 2023 - πΊπΈUnited States smustgrave
CR reads fine and trigger_error is there. No failures so think this is good.
- last update
8 months ago 30,483 pass - last update
8 months ago 30,486 pass - last update
8 months ago 30,486 pass - last update
8 months ago 30,493 pass - last update
8 months ago 30,512 pass - Status changed to Needs work
8 months ago 12:03am 11 November 2023 The Needs Review Queue Bot β tested this issue.
While you are making the above changes, we recommend that you convert this patch to a merge request β . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)
- First commit to issue fork.
- @_shy opened merge request.
- Status changed to Needs review
8 months ago 11:35am 11 November 2023 - Status changed to RTBC
8 months ago 6:05pm 11 November 2023 - Status changed to Fixed
6 months ago 9:26am 17 December 2023 - π¬π§United Kingdom alexpott πͺπΊπ
Committed 58777e0 and pushed to 11.x. Thanks!
diff --git a/core/lib/Drupal/Core/Access/CustomAccessCheck.php b/core/lib/Drupal/Core/Access/CustomAccessCheck.php index c7d0b5657a..fcdaabf16e 100644 --- a/core/lib/Drupal/Core/Access/CustomAccessCheck.php +++ b/core/lib/Drupal/Core/Access/CustomAccessCheck.php @@ -46,7 +46,7 @@ class CustomAccessCheck implements RoutingAccessInterface { */ public function __construct(ControllerResolverInterface|CallableResolver $callable_resolver, AccessArgumentsResolverFactoryInterface $arguments_resolver_factory) { if ($callable_resolver instanceof ControllerResolverInterface) { - @trigger_error('Calling ' . __METHOD__ . '() with an argument of ControllerResolverInterface is deprecated in drupal:10.2.0 and is removed in drupal:11.0.0. Use \Drupal\Core\Utility\CallableResolver instead. See https://www.drupal.org/node/3397706', E_USER_DEPRECATED); + @trigger_error('Calling ' . __METHOD__ . '() with an argument of ControllerResolverInterface is deprecated in drupal:10.3.0 and is removed in drupal:11.0.0. Use \Drupal\Core\Utility\CallableResolver instead. See https://www.drupal.org/node/3397706', E_USER_DEPRECATED); $callable_resolver = \Drupal::service('callable_resolver'); } $this->callableResolver = $callable_resolver;
Changed deprecation version to 10.3.0 on commt.
-
alexpott β
committed 9e3a13aa on 11.x
Issue #3363423 by _shY, vbouchet: Use CallableResolver for \Drupal\Core\...
-
alexpott β
committed 9e3a13aa on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.