- Issue created by @kim.pepper
- Merge request !4253Issue #3363420: Use CallableResolver for \Drupal\Core\Render\Renderer::doCallback() → (Closed) created by kim.pepper
- last update
12 months ago 29,384 pass, 4 fail - Status changed to Needs work
12 months ago 7:08am 26 June 2023 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Leaving this here for my future self: The tests are likely failing because ControllerResolver was previously called conditionally, so just returned NULL for most test cases. We need to return something from the mock CallableResolver, or create a real one.
- last update
8 months ago 30,247 pass, 4 fail - last update
8 months ago 30,417 pass - Status changed to Needs review
8 months ago 5:06am 19 October 2023 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Fixed up some of the test fails.
- Status changed to RTBC
8 months ago 5:14pm 19 October 2023 - 🇺🇸United States smustgrave
Deprecation seems good and CR is sweet and simple.
- last update
8 months ago 30,425 pass - last update
8 months ago 30,425 pass, 1 fail - last update
8 months ago 30,435 pass, 1 fail - last update
8 months ago 30,437 pass, 1 fail - Status changed to Fixed
8 months ago 10:15pm 27 October 2023 - 🇬🇧United Kingdom longwave UK
Committed and pushed a39939bb26 to 11.x and 0a6f0f4196 to 10.2.x. Thanks!
Also published the change record.
-
longwave →
committed 0a6f0f41 on 10.2.x
Issue #3363420 by kim.pepper: Use CallableResolver for \Drupal\Core\...
-
longwave →
committed 0a6f0f41 on 10.2.x
-
longwave →
committed a39939bb on 11.x
Issue #3363420 by kim.pepper: Use CallableResolver for \Drupal\Core\...
-
longwave →
committed a39939bb on 11.x
- Status changed to Needs work
8 months ago 3:12am 28 October 2023 - 🇳🇿New Zealand quietone New Zealand
This broke HEAD for 10.2x and 11.x. For example, https://www.drupal.org/pift-ci-job/2796055 →
-
quietone →
committed 830dbf1d on 11.x
Revert "Issue #3363420 by kim.pepper: Use CallableResolver for \Drupal\...
-
quietone →
committed 830dbf1d on 11.x
- @kimpepper opened merge request.
- Status changed to Needs review
8 months ago 6:44am 28 October 2023 - 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
Looks like this needed a test run they tests passed before it was merged.
-
quietone →
committed 2b20452a on 10.2.x
Revert "Issue #3363420 by kim.pepper: Use CallableResolver for \Drupal\...
-
quietone →
committed 2b20452a on 10.2.x
- Status changed to Needs work
8 months ago 9:22am 28 October 2023 - 🇳🇿New Zealand quietone New Zealand
I made a mistake and reverted the wrong issue on 10.2.x, 📌 Use CallableResolver for \Drupal\Core\Menu\MenuLinkTree::transform() Fixed , instead of this one.
That should all be fixed now.
- Status changed to RTBC
8 months ago 9:25am 28 October 2023 - 🇬🇧United Kingdom longwave UK
Oops, commit code check ran locally but I did not run the tests, not sure I would have caught this anyway without a full test run.
Tests are green again so back to RTBC.
- Status changed to Needs review
8 months ago 10:47am 28 October 2023 - 🇫🇮Finland lauriii Finland
Asked a question about removing the property in the MR
- Status changed to RTBC
8 months ago 12:12pm 28 October 2023 - 🇬🇧United Kingdom longwave UK
Willing to be proven wrong here but I think extending the renderer service is unlikely.
- Status changed to Fixed
8 months ago 12:45pm 28 October 2023 - 🇫🇮Finland lauriii Finland
I found couple instances where the class was being extended in https://git.drupalcode.org/search?group_id=2&repository_ref=&scope=blobs... but none of them were using
::controllerResolve.Committed b3be7fb and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.
