Use CallableResolver for \Drupal\Core\Render\Renderer::doCallback()

Leaving this here for my future self: The tests are likely failing because ControllerResolver was previously called conditionally, so just returned NULL for most test cases. We need to return something from the mock CallableResolver, or create a real one.

Fixed up some of the test fails.

Deprecation seems good and CR is sweet and simple.

Committed and pushed a39939bb26 to 11.x and 0a6f0f4196 to 10.2.x. Thanks!

Also published the change record.

This broke HEAD for 10.2x and 11.x. For example, https://www.drupal.org/pift-ci-job/2796055 →

Looks like this needed a test run they tests passed before it was merged.

I made a mistake and reverted the wrong issue on 10.2.x, 📌 Use CallableResolver for \Drupal\Core\Menu\MenuLinkTree::transform() Fixed , instead of this one.

That should all be fixed now.

Oops, commit code check ran locally but I did not run the tests, not sure I would have caught this anyway without a full test run.

Tests are green again so back to RTBC.

Asked a question about removing the property in the MR

Willing to be proven wrong here but I think extending the renderer service is unlikely.

lauriii → closed merge request !5162

I found couple instances where the class was being extended in https://git.drupalcode.org/search?group_id=2&repository_ref=&scope=blobs... but none of them were using ::controllerResolve.

Committed b3be7fb and pushed to 11.x. Also cherry-picked to 10.2.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

kim.pepper → closed merge request !4253