- Issue created by @Shanu Chouhan
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:11am 25 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Why is
--standard=Drupal
used instead of--standard=Drupal,DrupalPractice
? - 🇮🇳India Shanu Chouhan
Hii @apaderno,
I addressed DrupalPractice issue here https://www.drupal.org/project/fakelogin/issues/3362606 📌 \Drupal::service('router.builder')->rebuild() call should be avoided in classes, Use dependency injection instead in drupal Database Closed: duplicate - Status changed to Needs work
over 1 year ago 7:09am 26 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
- // replace default user login with a fake form. + // Replace default user login with a fake form.
Since that comment is edited, a definite article should be added before default user; form should be added after user login.
- Status changed to Needs review
over 1 year ago 7:40am 31 May 2023 - 🇮🇳India ashutosh ahirwal India
Tried to fixes the issue.
providing patch please review. - thakurnishant_06 India
Hello Folks !!
I have tested the #6 patch and the phpcs issues has been successfully fixed! The patch was tested on Drupal 9.5.9 and PHP 8.2.4. To provide you with a comprehensive view, I will be adding both a before and after screenshot.
Thank you for your support! - Status changed to Needs work
over 1 year ago 2:55pm 1 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ /** + * {@inheritdoc} + */ + public function __construct(RouteBuilderInterface $routeBuilder) {
The description for a constructor must start with
Constructs a new
followed by the class name (including its namespace), and end withobject.
The documentation comment for a constructor must describe the parameters.- //$this->messenger()->addStatus($this->t('Your username is @username', ['@username' => $form_state->getValue('name')])); + // $this->messenger()->addStatus($this->t('Your username is @username', [ + // '@username' => $form_state->getValue('name') + // ]));
Commented out code must still be correctly indented.
- //Route options + // Route options. [ '_maintenance_access' => TRUE, - ] + ]
Rather than editing the comment, I would remove it.
- // replace default user login with a fake form. + // Replace default user login with a fake form.
The definite article is missing before default user login. form is missing after default user login.
- Assigned to nitin_lama
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 6:28am 2 June 2023 - Status changed to Needs work
over 1 year ago 9:34am 2 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ /** + * Constructs a new FakeLoginConfigForm instance.
The class namespace is missing.
- // rebuild the router. - \Drupal::service('router.builder')->rebuild(); + // Rebuild the router. + $this->routeBuilder->rebuild();
I would rather remove that comment, as
$this->routeBuilder->rebuild();
does not need explanations.- //$this->messenger()->addStatus($this->t('Your username is @username', ['@username' => $form_state->getValue('name')])); + // $this->messenger()->addStatus($this->t('Your username is @username', [ + // '@username' => $form_state->getValue('name') + // ]));
Commented out code still needs to be indented how code should be intended. (That means that
'@username' => $form_state->getValue('name')
must be indented by two spaces more.)
I would rather remove that commented-out code as it seems more debugging code that should not be left in a public release.- // replace default user login with a fake form. + // Replace the default user login with a fake form.
form is still missing after default user login.
- Status changed to Needs review
over 1 year ago 10:00am 2 June 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #11 by addressing #13, please review it.
Thanks!
-
g089h515r806 →
committed 923556f4 on 1.0.x authored by
mrinalini9 →
Issue #3362612 by nitin_lama, mrinalini9, Shanu Chouhan, Ashutosh...
-
g089h515r806 →
committed 923556f4 on 1.0.x authored by
mrinalini9 →
- Status changed to Fixed
over 1 year ago 7:55am 3 June 2023 Automatically closed - issue fixed for 2 weeks with no activity.