- Issue created by @Shanu Chouhan
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 7:54am 25 May 2023 - Status changed to Needs work
over 1 year ago 7:13am 26 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ /** + * Constructs the FakeLoginConfigForm. + * + * @param \Drupal\Core\Routing\RouteBuilderInterface $router_builder + * The route builder.
The description for a constructor must start with
Constructs a new
followed by the class name (including its namespace), and end withobject.
+ /** + * @param ContainerInterface $container + * + * @return static + */ + public static function create(ContainerInterface $container) {
That is not the documentation comment for a method inherited from a parent class or defined in an interface.
- Status changed to Needs review
over 1 year ago 9:13am 26 May 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #2 by addressing #3, please review it.
Thanks!
- Status changed to Needs work
over 1 year ago 1:27pm 26 May 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
+ /** + * Constructs a new FakeLoginConfigForm object. + *
The description for a constructor must start with
Constructs a new
followed by the class name (including its namespace), and end withobject.
- Assigned to sourabhjain
- Issue was unassigned.
- 🇮🇳India sourabhjain
@apaderno, The description contains all the points which you have described.
Please let us know what desc you are expecting. - Status changed to Needs review
over 1 year ago 10:15am 2 June 2023 - 🇮🇳India mrinalini9 New Delhi
Updated patch #4 by addressing #8, please review it.
Thanks!
- 🇮🇹Italy apaderno Brescia, 🇮🇹
+ /** + * Constructs a new Drupal\fakelogin\Form\FakeLoginConfigForm object. + * + * @param \Drupal\Core\Routing\RouteBuilderInterface $router_builder + * The route builder. + */
That description contains the class namespace too. The previous change was different.
+ /** + * Constructs a new FakeLoginConfigForm object. + * + * @param \Drupal\Core\Routing\RouteBuilderInterface $router_builder + * The route builder. + */
FakeLoginConfigForm
alone does not include the class namespace. - Status changed to Closed: duplicate
over 1 year ago 11:42am 2 June 2023 - 🇮🇹Italy apaderno Brescia, 🇮🇹
Since these changes are already applied in another issue, this issue is a duplicate of that issue.