Fix PHPStan L1 errors "Cannot unset offset 'foo' on array<int, string>."

Issue created by @Spokje
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,380 pass
@spokje opened merge request.
Status changed to Needs review about 1 year ago10:02am 9 May 2023
Comment about 1 year ago →
🇳🇱Netherlands Spokje
Comment about 1 year ago →
🇳🇱Netherlands Spokje
Note: I tried adding an @return string[] to \Drupal\Core\DependencyInjection\DependencySerializationTrait::__sleep, also to it's return, but somehow PHPStan doesn't pick up on it.
Status changed to RTBC about 1 year ago1:20pm 9 May 2023
Comment about 1 year ago →
🇺🇸United States smustgrave
Applied the MR and searched for "Cannot unset offset" and the 7 instances were removed.

Looks good to me.
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,383 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,388 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,387 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,387 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,387 pass, 2 fail
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,395 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,399 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,399 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,400 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,409 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,409 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,415 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,420 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,420 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,425 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
55:33
52:13
Running
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,430 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,430 pass
Open in Jenkins → Open on Drupal.org →
Environment: PHP 8.1 & MySQL 5.7
last update about 1 year ago
29,430 pass
Comment about 1 year ago →
🇬🇧United Kingdom longwave UK
Committed and pushed cc97afe40d to 11.x (10.2.x). Thanks!
Status changed to Fixed about 1 year ago1:12pm 22 June 2023
Comment about 1 year ago →
System Message

longwave → committed cc97afe4 on 11.x
Issue #3359048 by Spokje, smustgrave: Fix PHPStan L1 errors "Cannot...
Comment about 1 year ago →
System Message
Spokje → closed merge request !3961
Comment 12 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Fix PHPStan L1 errors "Cannot unset offset 'foo' on array<int, string>."

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments & Activities