Fix the issues reported by phpcs

The issue summary should always describe what the issue is trying to fix and, in the case, of coding standards issues, show which command has been used, which arguments have been used, and which report that command shown.

I have updated the issue description and also added command and arguments used.

Hi dineshkumarbollu

I applied your patch #2 to my local and I confirmed that your patch fixed PHPCS issues, however below are the remaining PHPCS issues that displays in my terminal

FILE: /Users/studenttrainees/Projects/drupalorgissues/docroot/modules/contrib/user_created_by/user_created_by.info.yml
----------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
----------------------------------------------------------------------------------------------------------------------

Time: 270ms; Memory: 8MB

Please also look at the screenshot attached for your reference.

Moving this to needs work to hear from you and even the maintainer if this issue should be fixed or not.

Thanks.

@clarkssquared can you tell which command are you using? Since, i'm not getting any errors/warning after applying patch #2 on branch 2.x

Hi nitin_lama

I executed the command below

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml user_created_by

based on my observation the issue that I raised will occur if the module is downloaded via composer, if you download the git repo the error that I commented will not appear. I only moved this ticket to needs work to get the attention of the maintainer or even the patch/MR owner if the issue should be fixed or if it can be ignored.

i will work on this :)

Hello @clarkssquared,
Created an updated patch to fix the remaining issues after applying patch #2 . Please review the patch.
adding screenshot of error after applying patch #2 for reference.
Thank You.

Tried applying above patch, got this error:

Checking patch README.txt...
Checking patch user_created_by.info.yml...
error: while searching for:
core_version_requirement: ^8 || ^9
dependencies:
 - drupal:views

# Information added by Drupal.org packaging script on 2021-11-03
version: '2.0.0'
project: 'user_created_by'
datestamp: 1635952656

error: patch failed: user_created_by.info.yml:5
error: user_created_by.info.yml: patch does not apply
Checking patch user_created_by.module...
Checking patch user_created_by.views.inc...