- Issue created by @nod_
- First commit to issue fork.
- Merge request !3822use of component-level CSS custom properties → (Closed) created by Unnamed author
- Status changed to Needs review
over 1 year ago 2:55am 13 April 2023 - 🇮🇳India Santosh_Verma
I have tested the MR #3822,
Confirm password variables now shifted into local scope from :rootNothing broken in the UI side
Week
Fair
Good
Strong
- Status changed to RTBC
over 1 year ago 6:35am 16 April 2023 - last update
over 1 year ago 29,202 pass - last update
over 1 year ago 29,283 pass - last update
over 1 year ago 29,283 pass - last update
over 1 year ago 29,302 pass - last update
over 1 year ago 29,304 pass - last update
over 1 year ago 29,343 pass - last update
over 1 year ago 29,366 pass - last update
over 1 year ago 29,366 pass - last update
over 1 year ago 29,371 pass - last update
over 1 year ago 29,378 pass - last update
over 1 year ago 29,379 pass - last update
over 1 year ago 29,380 pass - Status changed to Needs work
over 1 year ago 8:34pm 9 May 2023 - 🇺🇸United States bnjmnm Ann Arbor, MI
The MR is largely declaring variables within style blocks and using them in the following lines. These are block scoped so there's no way to override or reuse them, so these wind up being redundant and unnecessary
For example the MR
&.is-weak { --password-strength-bar-weak-border-color: var(--color-maximumred); --password-strength-bar-weak-bg-color: var(--color-maximumred); border-color: var(--password-strength-bar-weak-border-color); background-color: var(--password-strength-bar-weak-bg-color); }
Provides no advantage over
&.is-weak { border-color: var(--color-maximumred); background-color: var(--color-maximumred); }
- last update
over 1 year ago 29,380 pass - Status changed to Needs review
over 1 year ago 12:36pm 10 May 2023 - 🇮🇳India Santosh_Verma
Worked upon the suggestion given in #7, I believe that declaring variables in the styles block is redundant and unnecessary. I have addressed this issue in commit #8. Please take a look
- Status changed to RTBC
over 1 year ago 8:31pm 12 May 2023 - 🇺🇸United States smustgrave
Does appear point #7 has been addressed
- last update
over 1 year ago 29,388 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass 6:27 1:43 Running- last update
over 1 year ago 29,388 pass - last update
over 1 year ago 29,388 pass - Open on Drupal.org →Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - last update
over 1 year ago 29,395 pass - last update
over 1 year ago 29,399 pass - last update
over 1 year ago 29,399 pass - last update
over 1 year ago 29,400 pass - last update
over 1 year ago 29,409 pass - last update
over 1 year ago 29,409 pass - last update
over 1 year ago 29,415 pass - last update
over 1 year ago 29,420 pass - last update
over 1 year ago 29,420 pass - last update
over 1 year ago 29,425 pass - last update
over 1 year ago 29,429 pass - last update
over 1 year ago 29,430 pass - last update
over 1 year ago 29,429 pass, 2 fail - last update
over 1 year ago 29,430 pass - last update
over 1 year ago 29,436 pass - last update
over 1 year ago 29,436 pass 36:27 35:11 Running- last update
over 1 year ago 29,442 pass - last update
over 1 year ago 29,443 pass - last update
over 1 year ago 29,443 pass - last update
over 1 year ago 29,443 pass - last update
over 1 year ago 29,439 pass - last update
over 1 year ago 29,439 pass - last update
over 1 year ago 29,443 pass - last update
over 1 year ago 29,444 pass - last update
over 1 year ago 29,446 pass - last update
over 1 year ago 29,446 pass - last update
over 1 year ago 29,446 pass - last update
over 1 year ago 29,446 pass - last update
over 1 year ago 29,450 pass - Status changed to Needs review
over 1 year ago 7:11pm 23 July 2023 - Status changed to Needs work
over 1 year ago 7:01pm 24 July 2023 - last update
over 1 year ago 29,453 pass - Status changed to Needs review
over 1 year ago 4:03am 27 July 2023 - 🇮🇳India gauravvvv Delhi, India
Addressed feedback from comment #12, please review
- last update
over 1 year ago 29,453 pass - Status changed to RTBC
over 1 year ago 9:50pm 30 July 2023 - last update
over 1 year ago 29,455 pass - last update
over 1 year ago 29,455 pass - last update
over 1 year ago 29,457 pass - last update
over 1 year ago 29,458 pass 6:27 1:57 Running- last update
over 1 year ago 29,459 pass - last update
over 1 year ago 29,465 pass - last update
over 1 year ago 29,465 pass - last update
over 1 year ago 29,465 pass - last update
over 1 year ago 29,469 pass - last update
over 1 year ago 29,469 pass - last update
over 1 year ago 29,469 pass - 🇳🇿New Zealand quietone
I'm triaging RTBC issues → .
The issue summary doesn't have a proposed resolution but this does appear simple enough than maybe it is isn't needed here. I didn't find any unanswered questions. Leaving at RTBC.
- last update
over 1 year ago 29,467 pass, 2 fail - last update
over 1 year ago 29,469 pass - last update
over 1 year ago 29,469 pass - last update
over 1 year ago 29,470 pass - last update
over 1 year ago 29,470 pass - last update
over 1 year ago 29,470 pass - last update
over 1 year ago 29,471 pass - last update
over 1 year ago 29,471 pass - last update
over 1 year ago 29,471 pass - last update
over 1 year ago 29,473 pass - last update
over 1 year ago 29,473 pass - last update
over 1 year ago 29,477 pass - last update
over 1 year ago 29,477 pass - last update
over 1 year ago 29,482 pass - last update
over 1 year ago 29,482 pass - last update
about 1 year ago 29,482 pass - last update
about 1 year ago 29,485 pass 6:27 1:32 Running- last update
about 1 year ago 29,643 pass - last update
about 1 year ago 29,643 pass - last update
about 1 year ago 29,653 pass - last update
about 1 year ago 29,653 pass - last update
about 1 year ago 29,653 pass - last update
about 1 year ago 29,653 pass - last update
about 1 year ago 29,655 pass - last update
about 1 year ago 29,656 pass, 2 fail - last update
about 1 year ago 29,672 pass - last update
about 1 year ago 29,672 pass - last update
about 1 year ago 29,672 pass - last update
about 1 year ago 29,672 pass - last update
about 1 year ago 29,674 pass - last update
about 1 year ago 29,676 pass - last update
about 1 year ago 29,676 pass - last update
about 1 year ago 29,678 pass - last update
about 1 year ago 29,678 pass - last update
about 1 year ago 29,678 pass - last update
about 1 year ago 29,678 pass - last update
about 1 year ago 29,678 pass - last update
about 1 year ago 29,678 pass - last update
about 1 year ago 29,682 pass - last update
about 1 year ago 29,681 pass, 2 fail - last update
about 1 year ago 29,686 pass - last update
about 1 year ago 29,686 pass - last update
about 1 year ago 29,687 pass - last update
about 1 year ago 29,688 pass - last update
about 1 year ago 29,721 pass - last update
about 1 year ago 29,721 pass - last update
about 1 year ago 29,722 pass 51:26 47:37 Running-
lauriii →
committed c9453274 on 11.x
Issue #3353641 by Gauravvvv, Santosh_Verma, smustgrave, nod_, bnjmnm,...
-
lauriii →
committed c9453274 on 11.x
-
lauriii →
committed 8999e680 on 10.2.x
Issue #3353641 by Gauravvvv, Santosh_Verma, smustgrave, nod_, bnjmnm,...
-
lauriii →
committed 8999e680 on 10.2.x
- Status changed to Fixed
about 1 year ago 3:19pm 30 November 2023 Automatically closed - issue fixed for 2 weeks with no activity.